Item1356: (trunk) rdiff does not show any changes

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: Store
Branches:
Reported By: MichaelTempest
Waiting For:
Last Change By: CrawfordCurrie
On the trunk, rdiff shows no changes between revisions.

In Foswiki::UI::RDiff.pm, at about line 525, after the calls to Foswiki::Meta->load(), $topicObject{$r2}->getLoadedRev() does not match $r2. Same for $r1. Both "loaded revisions" are the same as the topic's latest revision. So the call to getDifferences returns no differences (because the latest revision is the same as the latest revision).

I am running trunk revision 3240, with RcsWrap.

-- MichaelTempest - 22 Mar 2009

Update: There is a conflict between these two functions/methods:
  • Foswiki::Store::VCStore::readTopic() returns $handler->numRevisions(), irrespective of the revision that was loaded.
  • Foswiki::Meta::reload() calls Foswiki::Store::VCStore::readTopic(), but it expects the return value to be the revision number of the revision that was loaded.

-- MichaelTempest - 22 Mar 2009

Thanks for the analysis Michael, I'll look into that.

-- CrawfordCurrie - 03 Apr 2009

Reckon that should fix it.

-- CrawfordCurrie - 03 Apr 2009

ItemTemplate edit

Summary (trunk) rdiff does not show any changes
ReportedBy MichaelTempest
Codebase trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Engine
Component Store
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:df19fb1fb00e
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r5 - 03 Apr 2009, CrawfordCurrie - This page was cached on 18 Sep 2019 - 19:50.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy