Foswiki on GitHub is open for business! Next release meeting: Monday September 29, 1300Z

Item1352: CompareRevisionsAddOn updated to use FSA architecture - eliminates problem with headers seen at the bottom of page and enables other enginers than CGI

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Extension CompareRevisionsAddOn  
CompareRevisionsAddOn does not work well with 1.0.4

In the compare screen you see two headers appended.

In the HTML source you can see that they are added AFTER the trailing /html tag.

CompareRevisionsAddOn is an old popular extension that I took over maintenance of when the original author slammed the door and left TWiki many years ago. It does all the rendering on its own and it has worked well since TWiki 4.0 only with some tweaks to the templates that comes with the addon.

But I am a bit stuck with this one.

I need some hints about how to get around it.

It is the Item923 "Adding two new fields to the default response header: Action and URI. read ExtraResponseHeaderFields for details" that has caused this new problem.

It is naturally the strange way the addon works that makes the 923 change not work.

I am hoping for a hint how I can either change the compare script or change the way it works so it does not have to render the whole thing itself.

For 1.1 I hope we can replace the current rdiff with the function of this addon. But for 1.0.4 we need this addon to work.

-- KennethLavrsen - 22 Mar 2009

I can confirm the problem. Porting CompareRevisionsAddOn to FSA architecture solves the problem and make this extension usable with engines other than CGI.

-- GilmarSantosJr - 22 Mar 2009

ItemTemplate edit

Summary CompareRevisionsAddOn updated to use FSA architecture - eliminates problem with headers seen at the bottom of page and enables other enginers than CGI
ReportedBy KennethLavrsen
Codebase
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component CompareRevisionsAddOn
Priority Normal
CurrentState Closed
WaitingFor
Checkins Foswikirev:3241 Foswikirev:3242 Foswikirev:3243
TargetRelease n/a
ReleasedIn
Topic revision: r6 - 22 Mar 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License