Item13502: CommentPlugin could expand variables on returned results when in AJAX mode

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.0.1
Target Release: patch
Applies To: Extension
Component: CommentPlugin
Branches: master Item13525
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
Suggested patch:

diff --git a/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin.pm b/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin.pm
index f727639..d6b1d4e 100755
--- a/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin.pm
+++ b/CommentPlugin/lib/Foswiki/Plugins/CommentPlugin.pm
@@ -222,7 +222,7 @@ sub _restSave {
                   . $output
                   . "\n</div>";
                 my $comment =
-                  Foswiki::Func::renderText( $output, $web, $topic );
+                  Foswiki::Func::expandCommonVariables( Foswiki::Func::renderText( $output, $web, $topic ) );
                 $response->print($comment);
             }
         }

-- GeorgeClark - 04 Jul 2015

Crawford, any reason you didn't do this? Seems like a simple enhancement.

-- GeorgeClark - 24 Jul 2015

Not sure. Did you run the testcases?

-- CrawfordCurrie - 24 Jul 2015

Yes, the unit tests pass.

-- GeorgeClark - 24 Jul 2015
 

ItemTemplate edit

Summary CommentPlugin could expand variables on returned results when in AJAX mode
ReportedBy GeorgeClark
Codebase 2.0.0, trunk
SVN Range
AppliesTo Extension
Component CommentPlugin
Priority Enhancement
CurrentState Closed
WaitingFor
Checkins distro:86bd0c36a93a
TargetRelease patch
ReleasedIn 2.0.1
CheckinsOnBranches master Item13525
trunkCheckins
masterCheckins distro:86bd0c36a93a
ItemBranchCheckins distro:86bd0c36a93a
Release01x01Checkins
Topic revision: r7 - 03 Aug 2015, GeorgeClark - This page was cached on 26 May 2016 - 16:40.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License