Item13495: images are broken in the WYSIWYG, when the web or topic contains unicode chars

Repo

• go to http://trunk.foswiki.org/Sandbox/Úň%C3%ADčôďě/ÁťťáčhméňťŤôp%C3%ADč
• try edit with WYSIWYG
• images are broken

-- JozefMojzis - 03 Jul 2015

Couple of issues going on:

1. The code unescapes the url and it no longer needs to
2. The SCRIPTURL macro now has arguments, It's more difficult to reverse it when building a url

-- GeorgeClark - 03 Jul 2015

And I've added a test for %PUBURL{ topic=" "   "file" }% That one is also broken, but that's expected I guess. But I noticed it's URL encoded. Do we need to still do the Foswiki::urlEncode($topic), ... etc, in Foswiki::Store::getAttachmentURL()? I removed the calls to urlEncode (experiment, not checked in!) and everything still seems to work fine in display. But not in edit, but that's expected.

Crawford, in general, these fixes need review. If you could check them out, I'll built RC3 on the 3rd, give us 24 hours to soak for the release. and then go for 2.0.

Also I think I might have broken backwards compatibility.

I opened Item13496 to figure out some way to detect and auto-stickey img tags that can't be round-tripped due to unusual macros. And our round-trip code needs to be enhanced to support the parameterized versions of the macros. But not for 2.0.

Thanks

-- GeorgeClark - 03 Jul 2015

Your fixes are good, but IMHO not serious enough to justify a new RC. Your analysis is quite right as far as it goes, but to support parameterised PUBURL etc macros requires an awful lot more work than we are able to do here. See Item13496

-- Main.CrawfordCurrie - 03 Jul 2015 - 06:48

Commenting is disabled while not logged in