You are here: Foswiki>Tasks Web>Item13450 (03 Aug 2015, GeorgeClark)Edit Attach

Item13450: SubscribePlugin with famfamfam skin breaks styling when button switches state.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.1
Target Release: patch
Applies To: Extension
Component: FamFamFamContrib, SubscribePlugin
Branches: master Item13525
Reported By: AdminUser
Waiting For:
Last Change By: GeorgeClark
View a topic with ?skin=famfamfam,pattern, and click the email icon to subscribe or unsubscribe. The request is processed, but when the button changes state in the javascript, it becomes unstyled text. Simple refresh of page renders the icon again. Note however that there is no difference in the icon for subscribe or unsubscribe.

-- AdminUser - 09 Jun 2015

Checking in a partial fix:
  • Add a subscribe.famfamfam.tmpl skin
  • Change jquery to replace the "title" instead of the "text" for an empty string

There are still some deficiencies. We really ought to give some visual feedback that 1) the event is processing, and 2) the subscription has been changed.

-- GeorgeClark - 15 Jul 2015

Crawford, setting this one for your review. It's a bit hackish. Had to split the templates into "spi:subscribe" and "spt:subscribe" for icon and text versions of the buttons. A simple template overlay won't work, since famfamfam needs both an icon at the top and a text link at the bottom.

Please set waiting for release if it looks okay. Thanks.

-- GeorgeClark - 15 Jul 2015

Looks fine to me.

-- Main.CrawfordCurrie - 20 Jul 2015 - 07:52
 
Topic revision: r9 - 03 Aug 2015, GeorgeClark - This page was cached on 02 Jul 2016 - 04:08.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License