You are here: Foswiki>Tasks Web>Item13327 (05 Jul 2015, GeorgeClark)Edit Attach

Item13327: Deep recursion at wrong web rename

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Component: FoswikiUIRename
Branches: master
Reported By: JozefMojzis
Waiting For:
Last Change By: GeorgeClark

Deep recursion at the web rename

How to reproduce

  • Create web Tutu
  • Go to WebPreferences
  • click rename web
  • set the new name to Tutux
  • Choose the new parent itself (Tutu)
  • click rename

Page long error message to user, and in the log:

[Tue Mar 24 22:31:12 2015] rename: Caught Deep Recursion Condition: /me/fw/utest2/foswiki/core/data/Tutu contains /me/fw/utest2/foswiki/core/data/Tutu/Tutux at /me/fw/utest2/foswiki/core/lib/Foswiki/Store/PlainFile.pm line 1313.

Of course, it is a stupidity trying rename and set the parent itself, but in the drop-down should not be shown itself's name - in this case Tutu.

-- JozefMojzis - 24 Mar 2015

I've added a check in UI::Rename to prevent setting the new parent to either the old or new webname. It's not as easy to remove the current web from the parent list. it would require adding a new parameter to the WEBLIST macro - to exclude the current web. And it wouldn't cover the case of trying to set the parent to the new webname.

-- GeorgeClark - 16 Apr 2015
 

ItemTemplate edit

Summary Deep recursion at wrong web rename
ReportedBy JozefMojzis
Codebase 1.2.0 beta1, trunk
SVN Range
AppliesTo Engine
Component FoswikiUIRename
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:a174877b273d
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:a174877b273d
ItemBranchCheckins
Release01x01Checkins
Topic revision: r5 - 05 Jul 2015, GeorgeClark - This page was cached on 30 Jul 2016 - 22:47.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License