Item12953: header parameter does not work when using row as fieldtype

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: EditRowPlugin
Branches: master
Reported By: WolfgangAlper
Waiting For:
Last Change By: GeorgeClark
header parameter does not work when using row as fieldtype.

Fails
%EDITTABLE{
   format="| row,1 | text,20,init |"
   header="|*Nr*|*Text*|"
}%
|||

Works
%EDITTABLE{
   format="| text,1 | text,20,init |"
   header="|*Nr*|*Text*|"
}%
|||

Also, table must not be empty. I.e this one fails as well (might be intended though). Note the missing |||
%EDITTABLE{
   format="| text,1 | text,20,init |"
   header="|*Nr*|*Text*|"
}%

-- WolfgangAlper - 02 Jul 2014

Crawford, I think that this is confirmed. I copied his first two examples - working and failing - to http://trunk.foswiki.org/Sandbox/TestItem12953 ... and neither of them display the header. So if one is working on 1.1.9, both are failing on trunk.

-- GeorgeClark - 02 Jul 2014

whoops. Reading the description, header= is used for the ability to create a completely empty table, so I removed the empty ||| line, saved and CRASH.

Use of uninitialized value in array element at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/TableCell.pm line 49.
 at /usr/local/lib/perl5/5.16/CGI/Carp.pm line 379.
   CGI::Carp::realdie("Use of uninitialized value in array element at /usr/home/trun"...) called at /usr/local/lib/perl5/5.16/CGI/Carp.pm line 468
   CGI::Carp::die("Use of uninitialized value in array element at /usr/home/trun"...) called at /usr/home/trunk.foswiki.org/core/lib/AssertOn.pm line 14
   Assert::__ANON__("Use of uninitialized value in array element at /usr/home/trun"...) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/TableCell.pm line 49
   Foswiki::Plugins::EditRowPlugin::TableCell::render(Foswiki::Plugins::EditRowPlugin::TableCell=HASH(0x805855690), HASH(0x805a1ab70), HASH(0x805a1ad80)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/TableRow.pm line 162
   Foswiki::Plugins::EditRowPlugin::TableRow::render(Foswiki::Plugins::EditRowPlugin::TableRow=HASH(0x805855360), HASH(0x805a1ab70), HASH(0x805a1ad80)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/Table.pm line 266
   Foswiki::Plugins::EditRowPlugin::Table::render(Foswiki::Plugins::EditRowPlugin::Table=HASH(0x805a5fba0), HASH(0x805a6f060)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin/View.pm line 182
   Foswiki::Plugins::EditRowPlugin::View::process("%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., "Sandbox", "TestItem12953", Foswiki::Meta=HASH(0x8042b6480)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins/EditRowPlugin.pm line 57
   Foswiki::Plugins::EditRowPlugin::commonTagsHandler("%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., "TestItem12953", "Sandbox", 0, Foswiki::Meta=HASH(0x8042b6480)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugin.pm line 312
   Foswiki::Plugin::invoke(Foswiki::Plugin=HASH(0x802a8cb70), "commonTagsHandler", "%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., "TestItem12953", "Sandbox", 0, Foswiki::Meta=HASH(0x8042b6480)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Plugins.pm line 380
   Foswiki::Plugins::dispatch(Foswiki::Plugins=HASH(0x80116e8b8), "commonTagsHandler", "%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., "TestItem12953", "Sandbox", 0, Foswiki::Meta=HASH(0x8042b6480)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 3529
   Foswiki::expandMacros(Foswiki=HASH(0x80116e630), "%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., Foswiki::Meta=HASH(0x8042b6480)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Meta.pm line 3208
   Foswiki::Meta::expandMacros(Foswiki::Meta=HASH(0x8042b6480), "%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"...) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 495
   Foswiki::UI::View::_prepare("%EDITTABLE{\x{a}   format=\"| row,1 | text,20,init |\"\x{a}   header=\"|"..., Foswiki::Meta=HASH(0x8042b6480), 0) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 475
   Foswiki::UI::View::view(Foswiki=HASH(0x80116e630)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 346
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.16/Error.pm line 421
   eval {...} called at /usr/local/lib/perl5/site_perl/5.16/Error.pm line 413
   Error::subs::try(CODE(0x801091510), HASH(0x80116e108)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 467
   Foswiki::UI::_execute(Foswiki::Request=HASH(0x802942e88), CODE(0x8010aafc0), "view", 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 299
   Foswiki::UI::handleRequest(Foswiki::Request=HASH(0x802942e88)) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 89
   Foswiki::Engine::CGI::run(Foswiki::Engine::CGI=HASH(0x8018c2570)) called at /home/trunk.foswiki.org/core/bin/view line 29.

-- GeorgeClark - 02 Jul 2014

And we go downhill. Probably a different issue, but I used the back button to get to a topic I could edit, and clicked edit, restored empty tables and save. Another crash in Foswiki::Prefs due to uninitialized variable. See Item12956

-- GeorgeClark - 02 Jul 2014

Fixed to work as per documentation/

-- CrawfordCurrie - 04 Nov 2014

 

ItemTemplate edit

Summary header parameter does not work when using row as fieldtype
ReportedBy WolfgangAlper
Codebase 1.1.9, trunk
SVN Range
AppliesTo Extension
Component EditRowPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:9d3c59521baa
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches master
trunkCheckins
masterCheckins distro:9d3c59521baa
ItemBranchCheckins
Release01x01Checkins
Topic revision: r6 - 05 Jul 2015, GeorgeClark - This page was cached on 25 Aug 2016 - 04:00.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License