Item1268: EditTablePlugin javascript does not save the changes in the last row of a table

Priority: Urgent
Current State: Closed
Released In: 1.0.4
Target Release: patch
Applies To: Extension
Component: EditTablePlugin
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
With javascript enabled EditTablePlugin does not save the last row of a table.

If the row has content the old content remains and the new is discarded.

If you add a row and save the content is empty

Disabling JS removes the bug

-- KennethLavrsen - 12 Mar 2009

Strange, I don't see that bug. Which topic do you see this?

-- ArthurClemens - 12 Mar 2009

Any edit table shows this. Incl TestCaseTableWithAllTypeEdits

But remember to refresh the browser cache so it is the new JS that runs. That fooled me this morning where I could not understand what Olivier meant. The browsers cache the old javascript. The minute I did control-F5 the bug can be seen.

And to really notice you need to play with a table without footer.

-- KennethLavrsen - 12 Mar 2009

That test runs fine on Mac FF. Perhaps a javascript on windows bug?

-- ArthurClemens - 13 Mar 2009

I use FF on Linux and I reported that bug, so it's not related to windows.

Perhaps a JS bug in FF on OS-X? smile

I'll update as soon as I can find some time to dig into this.

But this specific table is the only one that triggers that bug. All other ones I tested were fine. maybe it's because of it not having a %TABLE% header?!

-- OlivierRaginel - 13 Mar 2009

I have just tested TestCases.TestCaseTableWithAllTypeEdits on all major browsers, Mac and on Windows, IE6, IE7, FF, Chrome, Safari, and everything works fine. What more can I do?

I may not have tested with the same js as in svn.

-- ArthurClemens - 14 Mar 2009

Revision 3080 looks better, but needs testing.

-- ArthurClemens - 14 Mar 2009

No, this has problems with TestCaseTablesMacrosInMacros when moving rows.

-- ArthurClemens - 14 Mar 2009

The javascript code did not work well with footer rows, because these are not appended at the bottom as you see, but directly below the header rows. It took a lot of changes to make this work.

Now some more testing...

-- ArthurClemens - 15 Mar 2009

Currently the JS does not work at all in Release01x00 branch. I do not get any bottons for moving rows. I get the error message in both IE and FF that console is not an object or not defined.

-- KennethLavrsen - 15 Mar 2009

I was afraid for that, but it was too late to continue last night. Firebug has a nice logging functionality, but alas it fails on other browsers.

-- ArthurClemens - 15 Mar 2009

Fixed.

-- ArthurClemens - 15 Mar 2009
Topic revision: r31 - 19 Mar 2009, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License