cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item12368 (01 Feb 2013, GeorgeClark)Edit Attach

Item12368: Use of uninitialized value in lc at /bin/configure line 334, on windows.

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.7
Target Release: patch
Applies To: Engine
Component: Configure
Branches: Release01x01 trunk
Reported By: GeorgeClark TimotheLitt
Waiting For: GeorgeClark
Last Change By: GeorgeClark
On my Strawberry perl test system, this code executes but returns a defined empty string instead of undef. So with the patch, configure shows 'n/a' in the groups, but without the patch, it's just empty, and there are no errors.

diff --git a/core/bin/configure b/core/bin/configure
index ef1207c..503e3f9 100755
--- a/core/bin/configure
+++ b/core/bin/configure
@@ -332,7 +332,7 @@ if ($@) {
     # Run command without stderr output, to avoid CGI giving error.
     # Get names of primary and other groups.
     # This is down here because it takes 30s to execute on Strawberry perl
-    $::WebServer_gid = lc(qx(sh -c '( id -un ; id -gn) 2>/dev/null' 2>nul ));
+    $::WebServer_gid = lc(qx(sh -c '( id -un ; id -gn) 2>/dev/null' 2>nul ) || 'n/a');
 }

-- GeorgeClark - 24 Jan 2013

Re-opened to correct trunk fix - parallel code in the Engine daemon.

No change to 1.1.7, where the Engine daemon does not exist.

-- TimotheLitt - 25 Jan 2013

ItemTemplate edit

Summary Use of uninitialized value in lc at /bin/configure line 334, on windows.
ReportedBy GeorgeClark TimotheLitt
Codebase 1.1.6
SVN Range
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState Closed
WaitingFor GeorgeClark
Checkins distro:a3a3e6051e47 distro:d08da7998212 distro:1a40797991ce
TargetRelease patch
ReleasedIn 1.1.7
CheckinsOnBranches Release01x01 trunk
trunkCheckins distro:d08da7998212 distro:1a40797991ce
Release01x01Checkins distro:a3a3e6051e47
Topic revision: r9 - 01 Feb 2013, GeorgeClark - This page was cached on 21 Jun 2018 - 17:16.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy