You are here: Foswiki>Tasks Web>Item12337 (01 Feb 2013, GeorgeClark)Edit Attach

Item12337: Item11755 added an undocumented dependency on CPAN:HTML::TreeBuilder >= 4.0

Priority: Urgent
Current State: Closed
Released In: 1.1.7
Target Release: patch
Applies To: Extension
Component: CompareRevisionsAddOn
Branches: Release01x01 trunk
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
distro:fd699b2af534, cherry picked into 1.1.6 distro:2eb64fb4013a adds an undocumented dependency.

From the task Item11755

Looks like distro:2eb64fb4013a introduced a dependency to HTML:Treebuilder >= 4.0. the attribute "no_expand_entities" was first available in that version. Currently the dependencies state that version >= 3.23 are required. Unfortunately e.g CentOS 6.3 comes with version 3.23.

-- FrankHoellering - 08 Jan 2013

I'm not sure if the solution here is to document the new dependency, or revert the change for 1.1.7.
  • Conditional code? ( Test if can no_expand_entities and use it if available, otherwise use prior code?)

Centos 6.3 is not all that old, but HTML::TreeBuilder 3.23 dates from 2010.

I've made this a blocker for 1.1.7. But we were planning to release 1.1.7 this coming weekend, and I hate to delay it.

-- GeorgeClark - 09 Jan 2013

I need some help on this. Michael, do I revert the fix in Item11755 to remove the dependency? Sven indicated we should not change dependencies in a patch release, so that means I have no choice but to revert. Jan, and ideas? It was your fix that added the dependency.

-- GeorgeClark - 09 Jan 2013

After all this, are you sure that HTML::TreeBuilder needs to be > 4.0? Checking the old documentation: It appears that the no_expand_entities() is part of 3.23.

-- GeorgeClark - 09 Jan 2013

No, it definitely doesn't have that option yet. You were looking at 3.23_1, a dev version. The docs for the original 3.23 (which, by the way, isn't from 2010 but from 2006) don't mention no_expand_entities yet:

There's no way to fix it within HTML::TreeBuilder before 4.0, as far as I can tell, and since HTML::Entities is almost impossible to get to do something sensible, I'm going to commit a "fix" that makes it work with 3.23 but breaks special characters in that case. If anyone wants to come up with a better solution, be my guest.

-- JanKrueger - 09 Jan 2013

Update: it is possible to fix properly for all versions of H::TB. I've committed the change to trunk. We still don't have unit tests, but appears to work correctly for me. If that's good enough for you, feel free to merge to 01x01.

-- JanKrueger - 09 Jan 2013

FrankHoellering - any chance you could test the patch at distro:7b15a58808d7 to see if it resolves your dependency issue.

-- GeorgeClark - 10 Jan 2013

I reverted my local perl-HTML-Tree to 3.23, applied the patch to and it worked for me. Thank you for fixing this so quickly.

-- FrankHoellering - 10 Jan 2013

Thanks for testing. The fix will be in 1.1.7.

-- GeorgeClark - 10 Jan 2013
Topic revision: r14 - 01 Feb 2013, GeorgeClark - This page was cached on 14 Jan 2020 - 22:05.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy