You are here: Foswiki>Tasks Web>Item12297 (01 Feb 2013, GeorgeClark)Edit Attach

Item12297: Conditional initializing a perl variable exposes a core perl bug.

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.7
Target Release: patch
Applies To: Engine
Component:
Branches: Release01x01 trunk
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
See https://rt.perl.org/rt3/Ticket/Display.html?id=116110

If a variable is conditionally initialized, in some cases it will inherit from a different variable. These can be found using perlcritic.

The 1.2 configure issues will be fixed under a different task. This will cover 1.1 and the remaining items.


Trunk:  

perlcritic * |  grep Variable\ declared

Foswiki/Logger.pm: Variable declared in conditional statement at line 135, column 5. 
Foswiki/Net.pm: Variable declared in conditional statement at line 553, column 9.  
Foswiki/Configure/Package.pm: Variable declared in conditional statement at line 830, column 9.
Foswiki/Configure/UI.pm: Variable declared in conditional statement at line 1176, column 9.
Foswiki/Configure/Value.pm: Variable declared in conditional statement at line 211, column 5.
Foswiki/Plugins/AutoViewTemplatePlugin.pm: Variable declared in conditional statement at line 62, column 5.
Foswiki/Plugins/HomePagePlugin.pm: Variable declared in conditional statement at line 81, column 9.
Foswiki/Users/HtPasswdUser.pm: Variable declared in conditional statement at line 252, column 5.
Foswiki/Configure/Checkers/Certificate.pm: Variable declared in conditional statement at line 222, column 5.
Foswiki/Configure/Checkers/Certificate.pm: Variable declared in conditional statement at line 223, column 5.
Foswiki/Configure/Checkers/Certificate.pm: Variable declared in conditional statement at line 303, column 13.
Foswiki/Configure/Checkers/Certificate.pm: Variable declared in conditional statement at line 304, column 13.
Foswiki/Configure/Checkers/EMAILADDRESS.pm: Variable declared in conditional statement at line 47, column 9.
Foswiki/Configure/Checkers/EnableEmail.pm: Variable declared in conditional statement at line 631, column 9.
Foswiki/Plugins/WysiwygPlugin/Handlers.pm: Variable declared in conditional statement at line 816, column 5.
Foswiki/Configure/Checkers/Certificate/KeyChecker.pm: Variable declared in conditional statement at line 104, column 9.
Foswiki/Configure/Checkers/ConfigureGUI/Modals/SaveChanges.pm: Variable declared in conditional statement at line 47, column 5.

And in Release01x01

Foswiki/Configure/Package.pm: Variable declared in conditional statement at line 829, column 9.
Foswiki/Configure/UI.pm: Variable declared in conditional statement at line 659, column 9.
Foswiki/Plugins/AutoViewTemplatePlugin.pm: Variable declared in conditional statement at line 62, column 5.
Foswiki/Users/HtPasswdUser.pm: Variable declared in conditional statement at line 252, column 5.
Foswiki/Plugins/WysiwygPlugin/Handlers.pm: Variable declared in conditional statement at line 816, column 5.

-- GeorgeClark - 16 Dec 2012

 
Topic revision: r8 - 01 Feb 2013, GeorgeClark - This page was cached on 05 Dec 2016 - 19:11.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License