Item1221: EditTablePlugin cannot read a TABLE tag with macros

Priority:	CurrentState:	AppliesTo:	Component:	WaitingFor:
Urgent	Closed	Extension	EditTablePlugin

Below test case shows this.

When you edit the table and add a row the row is supposed to be inserted above the footer row. ETP is supposed to read the TABLE tag and see the footerrows="1"

The root cause is the ENCODE that I added to trigger the problem.

The ENCODE of 80 returns simply 80. It is the regex in ETP that reads the TABLE tag that stops at the }% of ENCODE. It is exactly the same problem we just fixed for the EDITTABLE tag. And needs same type of fix.

Even though it is silly to add a ENCODE it is common to use macros inside the TABLE tag and if this macro is of a type that takes parameters the ETP fails. This should be fixed.

Defining Table

Item	Cost (USD)	Comments
Mechanics	600	All mechanical parts
Board A	400	Main board
Board B	350	Controller board
PSU	300	Power Supply
Filter	700	Noise filter
Package	200	Enclosure

Cost of Items

-- KennethLavrsen - 08 Mar 2009

I see. The col width parameter gets translated to:

.foswikiTable#table2 td.foswikiTableCol0 {width:80%22%20%22START_EDITTABLEPLUGIN_TMP_TAG;}

-- ArthurClemens - 08 Mar 2009

Fixed in trunk.

-- ArthurClemens - 10 Mar 2009

Still a problem: the macro is saved expanded, so the original syntax is lost.

-- ArthurClemens - 10 Mar 2009

I not see this issue Arthur. In fact I have not been able to break the ETP all day

Remember that all macros in the ETP tag itself are supposed to expanded. If you want to specify a format where a Macro is saved as a macro when adding new rows you are supposed to use the $percnt and $quot syntax.

-- KennethLavrsen - 10 Mar 2009

Everything within EDITTABLE{...} gets expanded and saved back to the page. So any ENCODE macro is lost.

-- ArthurClemens - 10 Mar 2009

Ah. In the EDITTABLE tag. I see that now. That is a bad one that needs to be fixed.

Note that fixes must now happen in both trunk and Release01x00

-- KennethLavrsen - 10 Mar 2009

-- KennethLavrsen - 10 Mar 2009