Item1184: CALC inside table is not working

Priority: Urgent
Current State: Closed
Released In: 1.0.4
Target Release: patch
Applies To: Engine
Reported By: Foswiki:Main.KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
SpreadSheetPlugin CALC does not work if it is on the same topic as an EDITTABLE tag.

The interaction between the two seems borked.

Item Description Qty Reason Unit Price Total Price
Hej Ho
Jah No

Conversion Specifier Description Before Description After
italic bold script=
==bold script=
bold italic
Keep as is
The full weekday name according to the current locale.
Keep as is
with br /
with BR macro

And inside normal text, with br / :


and with BR macro:


This bug makes me stop 1.0.3 release.

-- KennethLavrsen - 02 Mar 2009

Editing the tables to add TML formatting, so I can see what it's supposed to be doing.

-- OlivierRaginel - 02 Mar 2009

Moving the Foswiki::Plugins::EditTablePlugin::Core::prepareForView from beforeCommonTagsHandler to commonTagsHandler fixes this problem but re-introduces the huge problem that macros in a table are saved as their value instead of staying a macro.

I have inserted %WIKINAME% in the table above as an example. Edit and save should end up saving %WIKINAME% and not the value of %WIKINAME.

-- KennethLavrsen - 02 Mar 2009

Fixed: in handleTmlInViewMode variables are expanded now.

-- ArthurClemens - 02 Mar 2009

Thanks Arthur for fixing this so quickly.

And thanks also to Olivier for trying hard.

I will give it a good testing today at work.

-- KennethLavrsen - 03 Mar 2009

Fixed the unit test.

-- ArthurClemens - 03 Mar 2009

Removed my comments which were wrong.

Re-opening the bug so I can merge the re-factoring I did while analyzing this bug. I hope Arthur you like the way I re-factored, but as you implemented some of the things I did, I hope you will.

Also, fixed one bug (if you clicked "Cancel" with assert on, it would crash, as FSA no longer terminates upon redirects. (and merged this into Release01x00)

Arthur set this to "waiting for release", so I left it that way, even though I think it should be closed, as this was introduced between 1.0.0 and the next release.

-- OlivierRaginel - 03 Mar 2009
Topic revision: r24 - 19 Mar 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy