Foswiki on GitHub is open for business! Next release meeting: Monday October 13, 1300Z

Item11452: MetaCache robustness: remove from cache on $topicObject->finish()

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine   PaulHarvey
Presently, metacache can return a finished Foswiki::Meta obj if somebody somewhere has called $topicObject->finish().

This madness is/will be repaired in the store2 refactor (read-only topicObjects).

As most developers are naughty and generally don't ->finish() their objects in quite the sequence and circumstances (interactions with SEARCH) required to trigger this bug, nobody but me seems to have noticed.

-- PaulHarvey - 18 Jan 2012

Originally found while working on Item11431

-- PaulHarvey - 18 Jan 2012

Fn_SEARCH::test_metacache_madness was committed under Item11431, distro:7fa8ecad1d90 and distro:98f90cfd21a0

-- PaulHarvey - 19 Jan 2012

Fixed incorrect removeMeta return value on Release01x01

-- PaulHarvey - 19 Jan 2012

ItemTemplate edit

Summary MetaCache robustness: remove from cache on $topicObject->finish()
ReportedBy PaulHarvey
Codebase 1.1.4, 1.1.4 RC2, 1.1.4 RC1, 1.1.4 beta2, 1.1.4 beta1, trunk
SVN Range
AppliesTo Engine
Priority Normal
CurrentState Closed
WaitingFor PaulHarvey
Checkins distro:0e86c1336e3b distro:041aaa2871fe distro:e0f8d6e15f74
TargetRelease patch
ReleasedIn 1.1.5
CheckinsOnBranches Release01x01 trunk
trunkCheckins distro:0e86c1336e3b
Release01x01Checkins distro:041aaa2871fe distro:e0f8d6e15f74
Topic revision: r7 - 11 Apr 2012, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License