Item11417: CommentPlugin does not work with default text set.

pencil
Priority: Normal
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: CommentPlugin
Branches:
Reported By: MichaelLorenzen
Waiting For:
Last Change By: GeorgeClark

CommentPlugin does not work with default text set

Since 1.1.4 CommentPlugin does not render the comment box and button if a default text is set, like this: (% removed to prevent mis-targeted comments.)
 COMMENT{default="enter text here"}%

gives:

enter text here

-- MichaelLorenzen - 09 Jan 2012

added waiting for CrawfordCurrie

-- MichaelLorenzen - 13 Jan 2012

This is fixed in the trunk version of CommentPlugin.

-- GeorgeClark - 15 Jan 2012

Do I have to replace the whole plugin or can I just patch one file to get a quick fix?

-- MichaelLorenzen - 15 Jan 2012

The trunk version has been completely rewritten It's a great improvement - internally uses a registered tag handler instead of topic scraping, and comments using a rest handler instead of save, which permits anonymous commenting if desired.. There are a couple of things still left to be done - mainly, the strikeone javascript validation is not implemented.

I'll release this to Extensions/Testing.CommentPlugin a bit later today if you want to try the new version.

-- GeorgeClark - 15 Jan 2012

I think this is the right place to look at: foswiki.org/Extensions/Testing/WebHome ?

-- MichaelLorenzen - 16 Jan 2012

Yes, Sorry for the delay - I tripped over a couple of other issues in the new version. One I'm still working on are the last two examples on CommentPluginExamples. These use a custom form and submit the comment by posting to the save script. This technique no longer works, the new plugin needs a fix and the examples (and any home grown version) need to be reworked.

Finally, since the new plugin uses a rest handler, it's important to verify that you have protected the rest script as requiring login, or it can be possible to post comments anonymously.

-- GeorgeClark - 16 Jan 2012

Version 2.0.0 has been posted to Extensions/Testing.CommentPlugin Test carefully as this is a redesigned version of the plugin. Note other warnings in the extension topic.

-- GeorgeClark - 17 Jan 2012

I installed the testing CommentPlugin, until now everything seems ok. I'll add a new task, if I find anything unusal.

-- MichaelLorenzen - 17 Jan 2012

Why was this marked as waiting for me? Removed my name, and changed status to Confirmed.

-- CrawfordCurrie - 19 Jan 2012

Because you are listed as author of CommentPlugin

-- MichaelLorenzen - 19 Jan 2012

This task can go to Waiting for Release - the issue with default text is resolved in the new version. See Item11459 for continued discussion of the interoperation issue with WorkflowPlugin

-- GeorgeClark - 19 Jan 2012
 

ItemTemplate edit

Summary CommentPlugin does not work with default text set.
ReportedBy MichaelLorenzen
Codebase 1.1.4
SVN Range
AppliesTo Extension
Component CommentPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins
TargetRelease major
ReleasedIn 2.0.0
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r16 - 05 Jul 2015, GeorgeClark - This page was cached on 08 Dec 2016 - 05:05.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License