cross
Foswiki General Assembly will be held on 28th November 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly
You are here: Foswiki>Tasks Web>Item11366 (11 Apr 2012, GeorgeClark)Edit Attach

Item11366: Ampersands in [[squab?queries]] are double-encoded

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.5
Target Release: patch
Applies To: Engine
Component: FoswikiRender
Branches: Release01x01 trunk
Reported By: PaulHarvey
Waiting For:
Last Change By: GeorgeClark
Writing a new set of link tests for Item11356 (trunk-only work), I discovered that

this TML:
[[WebHome?q=r&s=t#f]]
Yields a link to
WebHome?q=r&s=t#f
, since the HTML looks like:
WebHome?q=r&s=t#f

This must be a long-standing bug (since support for ? in squabs was introduced in Foswiki 1.1.0?) but it sucks..

-- PaulHarvey - 17 Dec 2011

Definitely fails in 1.1.3 as well. Also confirmed failing back in 1.1.0.

-- GeorgeClark - 17 Dec 2011

I've made some attempts to fix this. This is one of those #^%@&^% double-(de)-re-encoding problems that I'm terrified of touching.

I can't say that I'm comfortable making a last-second fix for 1.1.4.

You can still use ; instead of & to delimit query params inside [[squabs]].

Let's fix this in 1.1.5.

-- PaulHarvey - 18 Dec 2011

George's simple fix seems to work out fine. I removed the usage of Foswiki::Address from the FormattingTests concerned.

-- PaulHarvey - 22 Feb 2012

Unit test fails if short URL's enabled. Change to expect failure.

-- GeorgeClark - 29 Mar 2012
 
Topic revision: r20 - 11 Apr 2012, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy