Foswiki on GitHub is open for business! Next release meeting: Monday September 29, 1300Z

Item11366: Ampersands in [[squab?queries]] are double-encoded

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine FoswikiRender  
Writing a new set of link tests for Item11356 (trunk-only work), I discovered that

this TML:
[[WebHome?q=r&s=t#f]]
Yields a link to
WebHome?q=r&s=t#f
, since the HTML looks like:
WebHome?q=r&s=t#f

This must be a long-standing bug (since support for ? in squabs was introduced in Foswiki 1.1.0?) but it sucks..

-- PaulHarvey - 17 Dec 2011

Definitely fails in 1.1.3 as well. Also confirmed failing back in 1.1.0.

-- GeorgeClark - 17 Dec 2011

I've made some attempts to fix this. This is one of those #^%@&^% double-(de)-re-encoding problems that I'm terrified of touching.

I can't say that I'm comfortable making a last-second fix for 1.1.4.

You can still use ; instead of & to delimit query params inside [[squabs]].

Let's fix this in 1.1.5.

-- PaulHarvey - 18 Dec 2011

George's simple fix seems to work out fine. I removed the usage of Foswiki::Address from the FormattingTests concerned.

-- PaulHarvey - 22 Feb 2012

Unit test fails if short URL's enabled. Change to expect failure.

-- GeorgeClark - 29 Mar 2012
 
Topic revision: r20 - 11 Apr 2012, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License