The foswiki svn repository will become read-only on Friday 8/8. Developers should register for a http://github.com/ account for commit access to foswiki.

Item11208: Creating new group without "Group" at the end does not return an error

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine AccessControl, TopicUserMappingContrib  
No validation is done on group names.

Steps to reproduce

  1. Go to WikiGroups page
  2. Click on Create a new group
  3. Enter a group name that does not end in Group

Expected result

An error message indicating the group name must end in Group, and ideally disabling the Create group button until that is the case

Actual results

I Got the message Attention Success adding users to group DavidKramer added to the DummyGNoEnd group. See WikiGroups to see the result. ". The group page was created, but the group did not appear on the WikiGroups page

Notes

* Confirmed with gac410 on IRC 10/27/2011 this should be marked urgent

-- DavidKramer - 27 Oct 2011

I'll fix this by throwing an Error::Simple in TopicUserMapper

For 1.1.4., it will state that it failed, and log an error to the Foswiki error log. Post 1.1.4, we need to get all of these errors translated by maketext and passed back to the user. That will be handled in Item11196

-- GeorgeClark - 28 Oct 2011
 

ItemTemplate edit

Summary Creating new group without "Group" at the end does not return an error
ReportedBy DavidKramer
Codebase 1.1.4 beta1, 1.1.3, trunk
SVN Range
AppliesTo Engine
Component AccessControl, TopicUserMappingContrib
Priority Urgent
CurrentState Closed
WaitingFor
Checkins Foswikirev:12920 Foswikirev:12921 Foswikirev:12923 Foswikirev:12925
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r8 - 17 Dec 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License