Foswiki on GitHub is open for business! Next release meeting: Monday September 29, 1300Z

Item11131: SubscribePlugin fails to unsubscribe a user when prior subscription is for a group

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Waiting for Release Extension MailerContrib, SubscribePlugin  
To duplicate bug:
  1. Create a WebNotify subscription for a group to particular topic, such as:
       * AdminGroup: TargetTopic
  2. Now add a %SUBSCRIBE{}% tag to TargetTopic
  3. Click on the rendered "Unsubscribe" link.
  4. Look at the entry in the WebNotify topic.

Note that:
  • SubscribePlugin correctly determined that the user is subscribed to the topic via their membership in AdminGroup.
  • SubscribePlugin incorrectly created an empty subscription for the user which 1) doesn't unsubscribe them from the target topic, but 2) does subscribe them to all topics.

This is clearly related to Item5949 but represents a slightly different use case due to the group subscription. To address this use case, SubscribePlugin would need to enter a explicit unsubscribe entry in WebNotify, such as:
   * SomeUser: - TargetTopic 

-- LynnwoodBrown - 14 Sep 2011

Confirmed, and added a unit test. Set to expect failure. The issue is in the changeSubscription of MailerContrib. It doesn't detect that it has to add a negative subscription to unsubscribe a user that is subscribed due to a group membership.

-- GeorgeClark - 14 Sep 2011

Discussed this with Crawford on IRC. The API that maintains the subscriptions does not make any attempt to deal with group subscriptions, so the Group subscription persists regardless of the setting for the specific user. This would have to be an enhancement / rewrite of the subscription API.

-- GeorgeClark - 19 Sep 2011

Fixing this by documenting the restriction in the SubscribePlugin topic.

-- GeorgeClark - 19 Sep 2011

ItemTemplate edit

Summary SubscribePlugin fails to unsubscribe a user when prior subscription is for a group
ReportedBy LynnwoodBrown
Codebase trunk
SVN Range
AppliesTo Extension
Component MailerContrib, SubscribePlugin
Priority Normal
CurrentState Waiting for Release
Checkins Foswikirev:12523 Foswikirev:12584 Foswikirev:12586 Foswikirev:12587
TargetRelease minor
ReleasedIn 1.2.0
Topic revision: r8 - 15 Dec 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License