Item11016: FamFamFam buttons do not pick up rev and queryparams for the print action.

Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Extension
Component: FamFamFamContrib
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
The Print action doesn't pick up the rev= or other query parameters. So print will always print the current revision of the topic, and will lose any URLPARAM based content.

%TMPL:DEF{"top:toolbarbutton_print"}%<span>
        <a href="%SCRIPTURL{"view"}%/%WEB%/%TOPIC%?cover=print" title="%MAKETEXT{"Printable version of this topic (p)"}%">
                <img alt="%MAKETEXT{"Printable version of this topic (p)"}%" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/printer.png" width="16" height="16" />
        </a></span>%TMPL:END%

should probably be:
%TMPL:DEF{"top:toolbarbutton_print"}%<span>
        <a href="%SCRIPTURL{"view"}%/%WEB%/%TOPIC%?cover=print;%QUERYSTRING%%REVARG%" title="%MAKETEXT{"Printable version of this topic (p)"}%">
                <img alt="%MAKETEXT{"Printable version of this topic (p)"}%" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/printer.png" width="16" height="16" />
        </a></span>%TMPL:END%

-- GeorgeClark - 02 Aug 2011

yes smile comited fixes, should re-publish, but my net isn't up to it atm.

-- SvenDowideit - 19 Aug 2011
 

ItemTemplate edit

Summary FamFamFam buttons do not pick up rev and queryparams for the print action.
ReportedBy GeorgeClark
Codebase 1.1.3, trunk
SVN Range
AppliesTo Extension
Component FamFamFamContrib
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:051f335a0c4a
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r6 - 17 Dec 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License