cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item10980 (17 Dec 2011, GeorgeClark)Edit Attach

Item10980: MailerContrib unit tests broken if run with HTMLValidationTests - exposed issue that might hit persistent perl environments.

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Engine
Component: MailerContrib
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
git bisect finds that distro:cdb8f73852e5 breaks the MailerContrib unit tests, but only if HTMLValidationTests are run ahead of MailerContrib suite.

Disabling the SubscribePlugin doesn't help.

../bin/TestRunner.pl -clean HTMLValidationTests.pm MailerContrib/
Options: -clean
exporting FOSWIKI_ASSERTS=1 for extra checking; disable by exporting FOSWIKI_ASSERTS=0
Assert checking on 1
Starting CWD is /var/www/foswiki/trunk/core/test/unit 
Running HTMLValidationTests
... <results all pass - omitted here> ...
Looking for MailerContrib...
        Found MailerContrib/MailerContribSuite.pm
Running MailerContribSuite
        MailerContribSuite::testSubweb
*** 
Expected mails for nonperson@example.com but only saw mails for email4@example.com email3@example.com test1@example.com test3@example.com email6@example.com email1@example.com email5@example.com jeltz@vogsphere.com email7@example.com person@example.com at MailerContrib//MailerContribSuite.pm line 383
        MailerContribSuite::testSubweb('MailerContribSuite=HASH(0xa079160)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0xa09dd68)', 'HASH(0xa09dc08)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('MailerContribSuite=HASH(0xa079160)', 'MailerContribSuite', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 137
        Unit::TestRunner::start('Unit::TestRunner=HASH(0x805e8c0)', 'HTMLValidationTests.pm', 'MailerContrib/') called

        MailerContribSuite::testExpansion
        MailerContribSuite::testExpansion_1847
        MailerContribSuite::test_changeSubscription_and_isSubScribedTo_API
*** 
Assertion failed at MailerContrib//MailerContribSuite.pm line 709
        MailerContribSuite::test_changeSubscription_and_isSubScribedTo_API('MailerContribSuite=HASH(0xa079160)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0xa2a4d08)', 'HASH(0xa2a4ba8)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('MailerContribSuite=HASH(0xa079160)', 'MailerContribSuite', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 137
        Unit::TestRunner::start('Unit::TestRunner=HASH(0x805e8c0)', 'HTMLValidationTests.pm', 'MailerContrib/') called

        MailerContribSuite::test_parseRealTopic
        MailerContribSuite::testCovers
        MailerContribSuite::testExcluded
        MailerContribSuite::testSimple
*** 
Expected mails for nonperson@example.com but only got email4@example.com email3@example.com test1@example.com test3@example.com email6@example.com email1@example.com email5@example.com email7@example.com jeltz@vogsphere.com person@example.com at MailerContrib//MailerContribSuite.pm line 327
        MailerContribSuite::testSimple('MailerContribSuite=HASH(0xa079160)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 383
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/trunk/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try('CODE(0xa3aea10)', 'HASH(0xa3ae8b0)') called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 402
        Unit::TestRunner::runOne('MailerContribSuite=HASH(0xa079160)', 'MailerContribSuite', undef) called at /var/www/foswiki/trunk/core/lib/Unit/TestRunner.pm line 137
        Unit::TestRunner::start('Unit::TestRunner=HASH(0x805e8c0)', 'HTMLValidationTests.pm', 'MailerContrib/') called

        MailerContribSuite::test_5949

Unit test run Summary:

3 failures:
112 of 115 test cases passed
1..3890

Running the MailerContrib test alone - everything passes

 ../bin/TestRunner.pl -clean  MailerContrib/
Options: -clean
exporting FOSWIKI_ASSERTS=1 for extra checking; disable by exporting FOSWIKI_ASSERTS=0
Assert checking on 1
Starting CWD is /var/www/foswiki/trunk/core/test/unit 
Looking for MailerContrib...
        Found MailerContrib/MailerContribSuite.pm
Running MailerContribSuite
        MailerContribSuite::testSubweb
        MailerContribSuite::testExpansion
        MailerContribSuite::testExpansion_1847
        MailerContribSuite::test_changeSubscription_and_isSubScribedTo_API
        MailerContribSuite::test_parseRealTopic
        MailerContribSuite::testCovers
        MailerContribSuite::testExcluded
        MailerContribSuite::testSimple
        MailerContribSuite::test_5949

Unit test run Summary:
All tests passed (9)
1..1033

-- GeorgeClark - 17 Jul 2011

Due to a m//o in the wrong place in the subscriptions parser.

-- CrawfordCurrie - 25 Jul 2011

Thinking about it, this needs to be merged to the patch branch. Simplest to synch the contrib.

-- CrawfordCurrie - 26 Jul 2011

 

ItemTemplate edit

Summary MailerContrib unit tests broken if run with HTMLValidationTests - exposed issue that might hit persistent perl environments.
ReportedBy GeorgeClark
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component MailerContrib
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:57d406618f86 distro:922e60a8d9ca distro:26f3e2d48fe6
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r8 - 17 Dec 2011, GeorgeClark - This page was cached on 12 Jul 2018 - 01:32.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy