You are here: Foswiki>Tasks Web>Item10951 (17 Dec 2011, GeorgeClark)Edit Attach

Item10951: Edit help is incorrect when WYSIWYG excluded due to topic content.

Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Extension
Component: TinyMCEPlugin
Reported By: FlorianPribahsnik
Waiting For:
Last Change By: GeorgeClark
When i edit a topic an the wyswig editor is not used, the link help link (twisty link) on top shows the wrong text. when the twisty opens the help for the wyswigeditor is shown even if you dont use him.

-- FlorianPribahsnik - 07 Jul 2011

We are going to need some more details on exactly how to create this. I've tested against 1.1.3. and the correct help text seems to be generated in 4 paths..
  • Wysiwyg (TinyMCE) editor
  • Wysiwyg (text edit) - (click wiki text button from TinyMCE)
  • Edit wiki text from view.
  • Main edit button with NOWYSIWYG set in topic

It also seems to work fine on - which is running the released 1.1.3.

Have you overridden any of the templates? I'm not sure what else to look for. Have you upgraded any plugins or other extensions or skins? Any local skin changes?

-- GeorgeClark - 07 Jul 2011

In our Wiki the option " Set WYSIWYG_EXCLUDE = html " is set. i don't know the exact mechansim,but on the bottom of every page there is an edit button. When i normally press this button the edit mode with WYSIWIG is opened.

The bug only occurs when an html tag is in the topic and WYSIWIG is not opened, only the raw text edit mode.

We have created our own skin.

-- FlorianPribahsnik - 14 Jul 2011

Okay - the "Set WYSIWYG_EXCLUDE = html" was the trick. I don't know much about WYSIWYG and TinyMCE, but I'm guessing that the late decision based upon topic content to bypass Wysiwyg happens after the twisty was written.

Setting this to confirmed, but not sure where to go from here.

-- GeorgeClark - 21 Jul 2011

Committed a fix - The exclude processing happened after the help text had been set. Added an undefine for the help message when exclude is triggered. One-line fix to If you want to apply it locally, click distro:3dc821ce4469 to see the code change.

-- GeorgeClark - 21 Jul 2011

ItemTemplate edit

Summary Edit help is incorrect when WYSIWYG excluded due to topic content.
ReportedBy FlorianPribahsnik
Codebase 1.1.3
SVN Range
AppliesTo Extension
Component TinyMCEPlugin
Priority Normal
CurrentState Closed
Checkins distro:a2408ded8e6c distro:3dc821ce4469
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r13 - 17 Dec 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy