NOTE: If you are a developer, please use a private wiki based on foswiki/trunk on a daily base ...or use trunk.foswiki.org to view this page for some minimal testing.
Use Item9693 for docu changes for 1.2 and 2.0.
You are here: Foswiki>Tasks Web>Item10937 (11 Apr 2012, GeorgeClark) Edit this topic text (e) Attach an image or document to this topic; manage existing attachments (a) View sequential topic history View without formatting (v) Create new topic Printable version of this topic (p) More: delete or rename this topic; set parent topic; view and compare revisions (m)

Item10937: View iterates through the revs when a revision directive isn't present

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Low Closed Engine View  
In View.pm:

my $requestedRev = Foswiki::Store::cleanUpRevID( $query->param('rev') );

...

if ( defined $requestedRev ) {

...

Foswiki::Store::cleanUpRevID returns 0 when a revision is not present, rather than undef, so you end up iterating through all the revisions on every view, regardless of whether a rev parameter was passed.

This should be

if ( $requestedRev ) {

-- TimHeilig - 01 Jul 2011

This should be fixed in 1.1.5. Part of Item11591

-- GeorgeClark - 09 Mar 2012
 

ItemTemplate edit

Summary View iterates through the revs when a revision directive isn't present
ReportedBy TimHeilig
Codebase 1.1.4, 1.1.3
SVN Range
AppliesTo Engine
Component View
Priority Low
CurrentState Closed
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.1.5
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Edit | Attach | Print version | History: r3 < r2 < r1 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r3 - 11 Apr 2012, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons LicenseGet Foswiki at sourceforge.net. Fast, secure and Free Open Source software downloads