Foswiki General Assembly will be held on 28th November 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly
You are here: Foswiki>Tasks Web>Item10937 (11 Apr 2012, GeorgeClark)Edit Attach

Item10937: View iterates through the revs when a revision directive isn't present

Priority: Low
Current State: Closed
Released In: 1.1.5
Target Release: patch
Applies To: Engine
Component: View
Reported By: TimHeilig
Waiting For:
Last Change By: GeorgeClark

my $requestedRev = Foswiki::Store::cleanUpRevID( $query->param('rev') );


if ( defined $requestedRev ) {


Foswiki::Store::cleanUpRevID returns 0 when a revision is not present, rather than undef, so you end up iterating through all the revisions on every view, regardless of whether a rev parameter was passed.

This should be

if ( $requestedRev ) {

-- TimHeilig - 01 Jul 2011

This should be fixed in 1.1.5. Part of Item11591

-- GeorgeClark - 09 Mar 2012

ItemTemplate edit

Summary View iterates through the revs when a revision directive isn't present
ReportedBy TimHeilig
Codebase 1.1.4, 1.1.3
SVN Range
AppliesTo Engine
Component View
Priority Low
CurrentState Closed
TargetRelease patch
ReleasedIn 1.1.5
Topic revision: r3 - 11 Apr 2012, GeorgeClark - This page was cached on 16 Nov 2019 - 12:20.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy