Foswiki on GitHub is open for business! Next release meeting: Monday Dec. 1, 1300Z

Item10937: View iterates through the revs when a revision directive isn't present

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Low Closed Engine View  
In View.pm:

my $requestedRev = Foswiki::Store::cleanUpRevID( $query->param('rev') );

...

if ( defined $requestedRev ) {

...

Foswiki::Store::cleanUpRevID returns 0 when a revision is not present, rather than undef, so you end up iterating through all the revisions on every view, regardless of whether a rev parameter was passed.

This should be

if ( $requestedRev ) {

-- TimHeilig - 01 Jul 2011

This should be fixed in 1.1.5. Part of Item11591

-- GeorgeClark - 09 Mar 2012
 

ItemTemplate edit

Summary View iterates through the revs when a revision directive isn't present
ReportedBy TimHeilig
Codebase 1.1.4, 1.1.3
SVN Range
AppliesTo Engine
Component View
Priority Low
CurrentState Closed
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.1.5
CheckinsOnBranches
trunkCheckins
Release01x01Checkins
Topic revision: r3 - 11 Apr 2012, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License