cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item10827 (17 Dec 2011, GeorgeClark)Edit Attach

Item10827: TWISTY sets empty cookie value for remember="off" instead of clearing it, causes excessive overhead

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Extension
Component: TwistyPlugin
Branches:
Reported By: VickiBrown
Waiting For:
Last Change By: GeorgeClark
TWISTY uses cookies to store "remembered" state. That makes sense. But it sets up cookies even when remember="off".

Aside from the fact that this is suboptimal and potentially inefficient, we've run into a bug with the Safari browser. If there are a LOT of TWISTY calls, the cookie overloads and Safari gets confused.

The confusion is a Safari probloem.

But in the case we investigated, all 100 (!!) TWISTY calls set remember="off" There doesn't need to be a cookie if the cookie isn't of value.

-- VickiBrown - 01 Jun 2011.

remember="off" sets an empty value for the pref instead of clearing the setting.

I have made a fix that will be effective in Foswiki 1.1.4. You can also grab TwistyPlugin 1.6.13 and the core javascript attached here.

-- ArthurClemens - 02 Jun 2011

 

ItemTemplate edit

Summary TWISTY sets empty cookie value for remember="off" instead of clearing it, causes excessive overhead
ReportedBy VickiBrown
Codebase 1.1.3
SVN Range
AppliesTo Extension
Component TwistyPlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:2b930e3d9fef distro:1db204f423b7 distro:813bf72a78f2
TargetRelease patch
ReleasedIn 1.1.4
Topic attachments
I Attachment Action Size Date Who Comment
foswikiPref_src.jsjs foswikiPref_src.js manage 11 K 02 Jun 2011 - 10:37 ArthurClemens foswiki.Pref javascript that included method clearPref
Topic revision: r13 - 17 Dec 2011, GeorgeClark - This page was cached on 15 Jul 2018 - 00:56.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy