New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item10801 (17 Dec 2011, GeorgeClark)Edit Attach

Item10801: Search is broken with PatternSkin on 1.0.9

Priority: Urgent
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Extension
Component: PatternSkin
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
Report from IRC, confirmed locally.

When PatternSkin is installed on Foswiki 1.0.9, the search results pages are empty.

The Extension form has been updated with a 1.1.x only warning.

-- GeorgeClark - 27 May 2011

Problem template is: PatternSkin/templates/search.pattern.tmpl - renaming the .bak file to restore the 1.0.9 version restores the search results.

-- GeorgeClark - 27 May 2011

Nothing else to be done right now, except for a direct download link to the old zip. But if they use the extension installer from configure it will give the old problem.

-- ArthurClemens - 27 May 2011

I don't see how we can fix this. But we do need to point users to the right (oder) version. And to not have the bug warning "*Foswiki 1.1.x ONLY* Breaks search on 1.0.x" forever (which likely diminishes your faith in foswiki's robustness) I would prefer to offer a separate download through the extension installer. For example as PatternSkin01x00 "for Foswiki version 1.0.0 to 1.0.9".

-- ArthurClemens - 27 May 2011

1.1's configure was enhanced at the last minute to supply release, version and pluginsapi as URLPARMs to FastReport.

So maybe we can think of a way to hide the latest PatternSkin from FastReport requests that omit this information (implies a 1.0.x install).

What is the fundamental reason that SEARCH is broken in PatternSkin now? Did some DEF get renamed? Can we not supply the missing def in a harmless way? Or is it some deeper problem?

-- PaulHarvey - 28 May 2011

I have 'fixed' the issue by re-introducing (legacy) TMPL:DEFs from older Foswiki that do not interfere with newer DEFs.

I have also re-released the skin to Extensions and removed the warning.

-- ArthurClemens - 28 May 2011

Cool smile

-- PaulHarvey - 28 May 2011

ItemTemplate edit

Summary Search is broken with PatternSkin on 1.0.9
ReportedBy GeorgeClark
Codebase 1.1.3, trunk
SVN Range
AppliesTo Extension
Component PatternSkin
Priority Urgent
CurrentState Closed
Checkins distro:f718cd2396e1 distro:f228c1ccdf00
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r10 - 17 Dec 2011, GeorgeClark - This page was cached on 22 Mar 2018 - 16:44.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License