Foswiki on GitHub is open for business! Next release meeting: Monday Nov. 17, 1300Z

Item10658: SEARCHDEFAULTTTYPE no longer referenced

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Normal Closed Engine Documentation, SEARCH  
Not sure if this is a documentation bug or a Search bug. However the setting SEARCHDEFAULTTTYPE is no longer referenced by the search code in 1.1. The only references I can find other than the settings themselves are in the 1.0.x Search.pm.

Should this be removed from the docs, or added back into Search?

-- GeorgeClark - 19 Apr 2011

Note that SEARCHVARDEFAULTTYPE and SEARCHSTOPWORDS are still used. It's only the SEARCHDEFAULTTTYPE that's gone missing.

-- GeorgeClark - 19 Apr 2011

Tasks.Item1354 might shed some illumination (or maybe not...)

-- WillNorris - 20 Apr 2011

http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs/Item6217

-- WillNorris - 20 Apr 2011

Confirming that Item6217 does restore operation of setting - however it is incomplete on our WebSearch form and needs to be changed in 5 places. However we have a bit of an issue in that any change will impact existing users:

Options:
  • Eliminate the setting.
  • Add it into the WebSearch - searchsimple - Changes default for current 1.1 users
  • Add it into the WebSearch - searchadvanced - Changes default for everyone

-- GeorgeClark - 20 Apr 2011

If the operation of WebSearch and its UI has changed then there may no longer be a good reason to keep it.

It is not impacting any searches that people has constructed using the SEARCH macro unless they have used the macro. And if they have we must assume they either have or can define it in their site prefs. Only re-add it if it adds value.

-- KennethLavrsen - 18 May 2011

I believe this only really effects WebSearch pages, and it did come up in a support question: Support.Question839. Sites that have modified the default type for the WebSearch page in Foswiki 1.0.x are broken on Foswiki 1.1.

Since there is a complaint, we should probably add the setting back in, and for consistency also add it to the WebSearchAdvanced page.

There is also the ParkedProposal Development.RemoveSearchDefaultType, which is now partly implemented on 1.1, even though the proposal has objections. The default has been removed, but is still documented and misspelled.

So unless the objections to the proposal are dropped, we should probably put back the setting at least for the WebSearch* pages. I have a the changes ready to go in a git stash.

-- GeorgeClark - 19 May 2011

Seems it adds value then. You should go ahead then. And thanks.

-- KennethLavrsen - 19 May 2011
 

ItemTemplate edit

Summary SEARCHDEFAULTTTYPE no longer referenced
ReportedBy GeorgeClark
Codebase 1.1.3, trunk
SVN Range
AppliesTo Engine
Component Documentation, SEARCH
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:c7adce311665 distro:2a734f7b2276
TargetRelease patch
ReleasedIn 1.1.4
Topic revision: r10 - 17 Dec 2011, GeorgeClark
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License