cross
New Foswiki release 2.1.6 is available with important security fixes.
Sourceforge foswiki email lists being discontinued. Subscribe to the new Foswiki announce and discuss lists at MailingLists
You are here: Foswiki>Tasks Web>Item10644 (17 Dec 2011, GeorgeClark)Edit Attach

Item10644: bin/changes output is corrupted

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Engine
Component: FoswikiTemplates, FoswikiUIChanges
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
There appear to be a couple of issues to the old bin/changes script output.

  • Foswiki::UI::Changes calls Meta::summariseChanges without passing the 'TML' option, so the change is a plain text (+ / -) diff style output. The script should generate TML for rendering.
  • The %AUTHOR% substitution in the template is corrupted.

I suspect the corruption of the AUTHOR is due to the changes to the templates to make sure that WikiNames are never rendered as broken links. Changes uses the search.pattern.tmpl: to display the results, The corrupted author is coming from the following:

 <span class="foswikiSRAuthor">%MAKETEXT{"by [_1] " args="%IF{"istopic '%AUTHOR%'" then="[[%AUTHOR%][$wikiname]]" else="$wikiname"}%"}%</span>

Where is $wikiname set from? The Changes script only sets %AUTHOR% However for some reason in the generated html, the truncated link is generated using &lt;

-- GeorgeClark - 17 Apr 2011

 
Topic revision: r7 - 17 Dec 2011, GeorgeClark - This page was cached on 20 Mar 2018 - 23:01.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License