Item10615: ActionTrackerPlugin does not update due date

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: ActionTrackerPlugin
Branches: trunk
Reported By: KerstinPuschke
Waiting For:
Last Change By: FlorianSchlichting
If you have defined one or more custom fields for your ACTIONs with ACTIONTRACKERPLUGIN_EXTRAS, but do not include some of them in ACTIONTRACKERPLUGIN_EDITHEADER, the ACTION's edit form breaks. It includes the respective fields as hidden, assigning (at least one of) them a value that looks like an html-encoded version of a form. If you save the edit form, this field is recorded with the value "<form method=" . Any changes to the due date are lost, changes to any other fields are saved.

Details: If I add a select named todo with options löschen, überarbeiten, OK to the ACTIONTRACKERPLUGIN_EXTRAS but do not include it in ACTIONTRACKERPLUGIN_EDITHEADER, my ACTION's edit form includes the following hidden field:

<input type="hidden" name="todo" value="&lt;form method=&quot;post&quot; action=&quot;%SCRIPTURLPATH{rest}%/ActionTrackerPlugin/update&quot; enctype=&quot;multipart/form-data&quot;&gt;&#10;&lt;input type=&quot;hidden&quot; name=&quot;topic&quot; value=&quot;Sandbox.UserFragen&quot;  /&gt;&lt;input type=&quot;hidden&quot; name=&quot;uid&quot; value=&quot;000223&quot;  /&gt;&lt;input type=&quot;hidden&quot; name=&quot;field&quot; value=&quot;todo&quot;  /&gt;&lt;input type=&quot;hidden&quot; name=&quot;value&quot; value=&quot;&quot;  /&gt;&lt;select name=&quot;todo&quot; class=&quot;atp_update userval&quot; size=&quot;1&quot;&gt;&lt;option value=&quot;NuLL&quot; selected=&quot;selected&quot;&gt;&lt;/option&gt;&lt;option value=&quot;&quot;&gt;&lt;/option&gt;&lt;option value=&quot;überarbeiten&quot;&gt;überarbeiten&lt;/option&gt;&lt;option value=&quot;löschen&quot;&gt;löschen&lt;/option&gt;&lt;option value=&quot;OK&quot;&gt;OK&lt;/option&gt;&lt;/select&gt;&#10;&lt;/form&gt;"  />

-- KerstinPuschke - 08 Apr 2011

Argh. Confirmed.

-- CrawfordCurrie - 18 May 2011

The problem was limited to select types, so was quite restricted in scope. Fixed.

-- CrawfordCurrie - 18 May 2011

The committed fix introduces a small annoyance where undefined fields cause a warning to be thrown:

[Tue Feb 14 11:28:23 2012] view: Use of uninitialized value in concatenation (.) or string at /some/path/lib/Foswiki/Plugins/ActionTrackerPlugin/Action.pm line 713.

Fixed with a check comparable to the one at the beginning of the function.

-- FlorianSchlichting - 15 Feb 2012
 
Topic revision: r11 - 17 Feb 2012, FlorianSchlichting - This page was cached on 25 Feb 2021 - 05:32.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy