Item10466: FamFamFam skin adds login/logout links

Priority: Normal
Current State: Closed
Released In: 1.1.3
Target Release: patch
Applies To: Extension
Component: FamFamFamContrib
Reported By: ArthurClemens
Waiting For:
Last Change By: KennethLavrsen
See current site.

-- ArthurClemens - 10 Mar 2011

I have removed the link from the site because it was an eyesore. Contrib needs to be fixed. Why is there a login/logout link in the tools area? It even doesn't have an icon.

-- ArthurClemens - 18 Mar 2011

I thought there was an icon - but the main reason is that on some skins, thats the only login UI.

Quite happy for it to go, now that FamFamFam isn't just my little toy.

I've made a change in svn - do you want to review it?

-- SvenDowideit - 19 Mar 2011

If I look at how it works on this site:
  • I see 2 login links, 1 of them is floating on the page
  • The casual visitor will not see that interaction is possible, because the tools are not visible. Of course he can scroll to the bottom and use the action links there.

-- ArthurClemens - 19 Mar 2011

i agree - I wrote famfamfam and ***Skin that way a long time ago for a skin that didn't have any other login/logout, and then used it for a client that did not want any tools visible until after the user logged in.

I quite agree that this is a corner case now.

(and I made changes for you to review - those changes are only in svn

-- SvenDowideit - 19 Mar 2011

Much better.

-- ArthurClemens - 19 Mar 2011

So these changes also need to be applied to release branch.

-- ArthurClemens - 20 Mar 2011


-- SvenDowideit - 28 Mar 2011
Topic revision: r15 - 16 Apr 2011, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy