You are here: Foswiki>Tasks Web>Item10425 (16 Apr 2011, KennethLavrsen)Edit Attach

Item10425: Undefined subroutine Foswiki::ENCODE - crash if URLENCODE alias is used

Priority: Urgent
Current State: Closed
Released In: 1.1.3
Target Release: patch

Applies To: Engine
Component:
Branches:

Reported By: SvenDowideit
Waiting For:
Last Change By: KennethLavrsen

Undefined subroutine &Foswiki::ENCODE - crash if URLENCODE alias is used

Removed & from the Summary - the character kills validation of the RSS Feed.

it seems that there is a URLENCODE alias for the ENCODE macro, which can crash foswiki - I found it when looking at TagsPlugin

[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] Undefined subroutine &Foswiki::ENCODE called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 3033.
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1]  at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 3033
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0x1307df8)', 'URLENCODE', 'Main', 'Foswiki::Meta=HASH(0x1d00a28)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 2923
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::_processMacros('Foswiki=HASH(0x1307df8)', '<span class="tagList">[[http://x61/m/bin/view/%URLENCODE{Main...', 'CODE(0x1263780)', 'Foswiki::Meta=HASH(0x1d00a28)', 15) called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 2941
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::_processMacros('Foswiki=HASH(0x1307df8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'CODE(0x1263780)', 'Foswiki::Meta=HASH(0x1d00a28)', 16) called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 2720
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::innerExpandMacros('Foswiki=HASH(0x1307df8)', 'SCALAR(0x12716c8)', 'Foswiki::Meta=HASH(0x1d00a28)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki.pm line 3210
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::expandMacros('Foswiki=HASH(0x1307df8)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x1d00a28)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/Meta.pm line 3016
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x1d00a28)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/UI/View.pm line 400
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::UI::View::_prepare('<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'Foswiki::Meta=HASH(0x1d00a28)', 0) called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/UI/View.pm line 360
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::UI::View::view('Foswiki=HASH(0x1307df8)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/UI.pm line 316
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \teval {...} called at /usr/share/perl5/Error.pm line 408
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tError::subs::try('CODE(0xa6af10)', 'HASH(0x13079a8)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/UI.pm line 435
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::UI::_execute('Foswiki::Request=HASH(0x12e35b8)', 'CODE(0x12a27a8)', 'view', 1) called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/UI.pm line 277
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::UI::handleRequest('Foswiki::Request=HASH(0x12e35b8)') called at /home/sven/src/Maxgaming/foswiki/lib/Foswiki/Engine/CGI.pm line 37
[Mon Feb 28 22:52:10 2011] [error] [client 127.0.1.1] \tFoswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0xdb1110)') called at /home/sven/src/Maxgaming/foswiki/bin/view line 24.

-- SvenDowideit - 28 Feb 2011

ItemTemplate edit

Summary	Undefined subroutine Foswiki::ENCODE - crash if URLENCODE alias is used
ReportedBy	SvenDowideit
Codebase	1.1.2
SVN Range
AppliesTo	Engine
Component
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:1bea23a1638d distro:7cd8e180b067
TargetRelease	patch
ReleasedIn	1.1.3