Item10285: FamFamFamContrib toolbar isn't multi language capable

Priority:	CurrentState:	AppliesTo:	Component:	WaitingFor:
Normal	Closed	Extension	FamFamFamContrib, I18N	Main.IngoKappler

The titles of the buttons used in the FamFamFamContrib toolbar aren't using %MAKETEXT%, so multiple languages are not supported. Since this contrib became standard, I consider it rather a bug than a feature request.

-- IngoKappler - 25 Jan 2011

Here are some explanations why things are done as shown here:

 %TMPL:INCLUDE{"view"}%
 %TMPL:DEF{"top:toolbarbutton_edit"}%<span>
-       <a href="%SCRIPTURL{"edit"}%/%WEB%/%TOPIC%?t=%GMTIME{"$epoch"}%" title="Edit this topic">
-               <img alt="edit" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/pencil.png" width="16" height="16" />
+       <a href="%SCRIPTURL{"edit"}%/%WEB%/%TOPIC%?t=%GMTIME{"$epoch"}%" title="%MAKETEXT{"Edit this topic text (e)"}%">
+               <img alt="%MAKETEXT{"Edit this topic text (e)"}%" src="%PUBURL%/%SYSTEMWEB%/FamFamFamSilkIcons/pencil.png" width="16" height="16" />
        </a></span>%TMPL:END%

1. The new %MAKETEXT% text is partially based on the titles already used in viewtopicactionbuttons.tmpl.
2. If applicable the short key was added.
3. Tests on IE 7 revealed that new titles didn't show up, instead the alternative text of the image takes precedence. I decided to keep the alt parameter but also using %MAKETEXT% as value. Alternatively the alt could have been removed altogether, then IE7 would display the title. But it is no option to remove the title because then Firefox won't display anything.

It is now up to translators to provide new translations for these new strings, preferably before 1.1.3.

Extension has been released. Still Waiting for Release as this is a default extension.

-- IngoKappler - 26 Jan 2011