Item10284: If Topic is not WikiWord, Rename will not list children to update

Priority: Urgent
Current State: Closed
Released In: 1.1.3
Target Release: patch
Applies To: Engine
Component:
Reported By: VickiBrown
Waiting For:
Last Change By: KennethLavrsen
If a Topic name is not a WikiWord, and the Topic is a parent topic, an attempt to Rename will not list the children in the "Update links" section.

Note: Duplicate of Item9966

Example:

In Sandbox, I have the topic VickiBrown

I created the topic Tmp1 and set it as the parent of VickiBrown

Item10284a.png

When I try to rename Tmp1,

it does not list any other Topics in the Update Links section.

Item10284b.png

-- VickiBrown - 25 Jan 2011

This is a bit tricky because rename generally only modifies "linking" references. For topics that are not wikiwords, it would only rename explicit linking references. However for macro params and metadata, quoted strings are also matched. I'm trying to construct a unit test to verify rename of the PARENT metadata.

-- GeorgeClark - 26 Jan 2011

Checking in a Fix - for trunk only for now. Added a new condition for the Regex generation for updates. $options->{inMeta} set when processing the META entries. For non-wikiword items, regex returns a non-delimited string for an exact match. This code is fragile, so feedback needed before committing to the release branch.

-- GeorgeClark - 29 Jan 2011

Hmmmmm. Would be great if Foswiki::Func::registerMETA() (and its core equivalent) would declare which fields in a META schema are "topic references", so Rename can update those refs more intelligent-o-matically.

But I have no objection to your current fix

-- PaulHarvey - 31 Jan 2011

The unit tests are failing on the nightly tests. However other than that system, no-one else has yet to report the failure. I'm guessing it's an issue with the grep regex used to find candidate topics. Here are the added regex. Could the failure be related to grep version?

-- GeorgeClark - 12 Feb 2011

We should ask Sven for a copy of his VM image... Or dpkg status file

-- PaulHarvey - 12 Feb 2011

Making this urgent - just to be sure the trace code is reverted prior to 1.1.3 build. Committed to debug the unit tests.

-- GeorgeClark - 06 Mar 2011

So in other words, there is trace code in Release01x01 right now that blocks me from building 1.1.3 RC?

-- KennethLavrsen - 06 Mar 2011

I've reverted the traces and updated RcsTests to restore some Sandbox settings that were breaking RenameTests for some reason. This is ready to release now.

-- GeorgeClark - 07 Mar 2011
 
Topic revision: r27 - 16 Apr 2011, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License