You are here: Foswiki>Tasks Web>Item10264 (05 Jul 2015, GeorgeClark)Edit Attach

Item10264: Change template-js-css logic from foswikiJs to foswikiNoJs.

Priority: Urgent
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Engine
Reported By: ArthurClemens
Waiting For:
Last Change By: GeorgeClark
Currently the core javascript jquery.foswiki.js adds a css classname foswikiJs to the html element that is subsequently used to hide/show page elements by css.

As raised in Tasks.Item10245 it would be better to reverse this logic and to have a foswikiNoJs tag in the html and remove that with javascript.

This makes it easier to style for the default (users have javascript, Foswiki may be used without but that is an edge case).

Implementation effect: because the html element cannot have a class tag, we need to move the default class to the body element. The check must then be done "on document ready".

-- ArthurClemens - 15 Jan 2011

I have updated:
  • Core:
    • templates/foswiki.tmpl
    • pub/System/SkinTemplates/base_src.css
  • PatternSkin:
    • templates/foswiki.pattern.tmpl
  • TwistyPlugin:
    • pub/System/TwistyPlugin/jquery.twisty.uncompressed.css (removed styles, and removed from MANIFEST)

Other skins need to be done. Priority set to urgent to not forget.

-- ArthurClemens - 15 Jan 2011

Must fix DefaultUserRegistration now.
  • Done

-- ArthurClemens - 17 Jan 2011


ItemTemplate edit

Summary Change template-js-css logic from foswikiJs to foswikiNoJs.
ReportedBy ArthurClemens
Codebase trunk
SVN Range
AppliesTo Engine
Priority Urgent
CurrentState Closed
Checkins distro:86e46920adfe distro:e5d5c2292103 distro:e2b9d9033b50 distro:81551ee31921
TargetRelease major
ReleasedIn 2.0.0
Topic revision: r10 - 05 Jul 2015, GeorgeClark - This page was cached on 01 Dec 2015 - 09:29. Get a fresh version here.
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License