Item10264: Change template-js-css logic from foswikiJs to foswikiNoJs

Priority: Urgent
Current State: Waiting for Release
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Reported By: ArthurClemens
Waiting For:
Last Change By: ArthurClemens
Currently the core javascript jquery.foswiki.js adds a css classname foswikiJs to the html element that is subsequently used to hide/show page elements by css.

As raised in Tasks.Item10245 it would be better to reverse this logic and to have a foswikiNoJs tag in the html and remove that with javascript.

This makes it easier to style for the default (users have javascript, Foswiki may be used without but that is an edge case).

Implementation effect: because the html element cannot have a class tag, we need to move the default class to the body element. The check must then be done "on document ready".

-- ArthurClemens - 15 Jan 2011

I have updated:
  • Core:
    • templates/foswiki.tmpl
    • pub/System/SkinTemplates/base_src.css
  • PatternSkin:
    • templates/foswiki.pattern.tmpl
  • TwistyPlugin:
    • pub/System/TwistyPlugin/jquery.twisty.uncompressed.css (removed styles, and removed from MANIFEST)

Other skins need to be done. Priority set to urgent to not forget.

-- ArthurClemens - 15 Jan 2011

Must fix DefaultUserRegistration now.
  • Done

-- ArthurClemens - 17 Jan 2011


ItemTemplate edit

Summary Change template-js-css logic from foswikiJs to foswikiNoJs
ReportedBy ArthurClemens
Codebase trunk
SVN Range
AppliesTo Engine
Priority Urgent
CurrentState Waiting for Release
Checkins distro:86e46920adfe distro:e5d5c2292103 distro:e2b9d9033b50 distro:81551ee31921
TargetRelease minor
ReleasedIn 1.2.0
Topic revision: r8 - 30 Aug 2011, ArthurClemens

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License