Item1017: EditTablePlugin again cannot save textareas with formatting because of wrong handling of new lines

Priority: Urgent
Current State: Closed
Released In: 1.0.1
Target Release: patch
Applies To: Extension
Component: EditTablePlugin
Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
Another old bug is back again

Here are a couple of Edit Tables

there's still a bug
lurking around

Some text
More text

Notice how links are not rendered and formatting does not work because there are no longer spaces added around the <br />

Another change is that the plugin now puts the html tag instead of %BR and this means old tables that have not been edited since are also loosing the formatting.

Please look carefully at all the bug reports when fixing because otherwise I bet those bugs come back. Try to edit and save using edit table many time and check the raw text saved. Be sure spaces do not get added each time.

Arthur fixed this on TWikibug:Item3883 with follow ups TWikibug:Item5208, TWikibug:Item5217, TWikibug:Item5211

I believe it was Gilmar that removed the feature again with TWikirev:16727 when developing the FSA and then later merged back to trunk.

This bug is a release blocker. It currently prevents me from upgrading to Foswiki. This bug is very very annoying in daily use. The users cannot remember to put dummy spaces around their text in table cells. I had quite many complaints about this from my beta testers.

-- KennethLavrsen - 07 Feb 2009

This is a bug that also exists in EditTablePlugin for TWiki version 4.9 (01 Nov 2008). Most fixes have been for %BR%, and some for adding spaces around cell contents, but these do not fix adjacent <br />TML.

-- ArthurClemens - 07 Feb 2009

Thanks for tasking care of this.

For the record. I misread the SVN checkins. Gilmer just merged the already updated plugin over to his scratch branch. It is around TWikirev:16544 the code was altered in connection with a major update of the plugin.

-- KennethLavrsen - 07 Feb 2009

The simpleness of the problem is deceiving. Creating the correct parsing of TML around HTML tags (even without spacing) means the rendering needs to be changed in view mode (whereas previous problems with BR and variables focussed exclusively on edit and save mode).

Simple adding spaces around the TML creates unexpected alignment (because the core table renderer - or table plugin) strips out html to determin the number of spaces at both sides.

To not deteriorate performance for just a few side cases in view mode I have now stored the parsed table object to let it be re-used in different functions. And the benefit is that I could remove all of the previous 'protect variables in edit mode' code.

-- ArthurClemens - 08 Feb 2009

ItemTemplate edit

Summary EditTablePlugin again cannot save textareas with formatting because of wrong handling of new lines
ReportedBy KennethLavrsen
Codebase trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component EditTablePlugin
Priority Urgent
CurrentState Closed
Checkins distro:d67821f3cac2
TargetRelease patch
ReleasedIn 1.0.1
Topic revision: r8 - 23 Feb 2009, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy