Item10121: Query across topic revisions

pencil
Priority: Enhancement
Current State: Proposal Required
Released In: n/a
Target Release: minor
Applies To: Engine
Component: SEARCH
Branches:
Reported By: CrawfordCurrie
Waiting For:
Last Change By: CrawfordCurrie
Implementation of QueryAcrossTopicRevisions

-- CrawfordCurrie - 05 Dec 2010

Patch attached to Item10129

-- CrawfordCurrie - 06 Dec 2010

I wrote some tests in http://trunk.foswiki.org/Sandbox/TestTopic44754, including a description of what I expected to see. In most cases, I didn't get what I expected after reading the documentation. I suspect that the code works fine and I misunderstood something, but that means there is something missing from the documentation.

I also put a trivial example in http://trunk.foswiki.org/Sandbox/TestTopic44755, and that causes breakage:
Assertion (Junk after </html>: '},'standardfooter' => {'text' => '
#PageBottom
TMPL:P{"footernote"}TMPL:P{"copyright"}'},'sep:_PREV' => {'text' => '<span class="foswikiSeparator"> | </span>'},'icon:search-small' => {'text' => '<span class="foswikiIcon"><img src="PUBURL/SYSTEMWEB/DocumentGraphics/search-small.png" width="13" height="13" alt="Search" /></span>'},
[snip]
</td></tr></table></div></div></div><div id="patternBottomBar"><div id="patternBottomBarContents"><div id="patternWebBottomBar"><span class="foswikiRight"> <a href="http://foswiki.org/"><img src="/pub/System/ProjectLogos/foswiki-badge.gif" alt="This site is powered by Foswiki" title="This site is powered by Foswiki" /></a></span>Copyright &copy; by the contributing authors. All material on this collaboration platform is the property of the contributing authors. <br /> Ideas, requests, problems regarding Foswiki? <a href='mailto:webmaster@foswiki.org?subject=Foswiki%20Feedback%20on%20Sandbox.TestTopic44755'>Send feedback</a></div></div></div>
</div>
</div>
</div>
</div></body></html>. Templates may be bogus
- Check for excess blank lines at ends of .tmpl files
-  or newlines after %TMPL:INCLUDE
- You can enable TRACE in Foswiki::Templates to help debug
) failed!
 at /usr/home/trunk.foswiki.org/core/lib/Assert.pm line 80
   Assert::ASSERT(0, 'Junk after </html>: \'},\'standardfooter\' => {\'text\' => \'...') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 824
   Foswiki::writeCompletePage('Foswiki=HASH(0x66b290)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'view', 'text/html') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 402
   Foswiki::UI::View::view('Foswiki=HASH(0x66b290)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 415
   eval {...} called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 407
   Error::subs::try('CODE(0x603c88)', 'HASH(0x9a5618)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x97e3c8)', 'CODE(0x6674d0)', 'view', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 274
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x97e3c8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 41
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x77f6a8)') called at /home/trunk.foswiki.org/core/bin/view line 29
 at /usr/home/trunk.foswiki.org/core/lib/Assert.pm line 80
   Assert::ASSERT(0, 'Junk after </html>: \'},\'standardfooter\' => {\'text\' => \'...') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki.pm line 824
   Foswiki::writeCompletePage('Foswiki=HASH(0x66b290)', '<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN...', 'view', 'text/html') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI/View.pm line 402
   Foswiki::UI::View::view('Foswiki=HASH(0x66b290)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 415
   eval {...} called at /usr/local/lib/perl5/site_perl/5.10.1/Error.pm line 407
   Error::subs::try('CODE(0x603c88)', 'HASH(0x9a5618)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x97e3c8)', 'CODE(0x6674d0)', 'view', 1) called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/UI.pm line 274
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x97e3c8)') called at /usr/home/trunk.foswiki.org/core/lib/Foswiki/Engine/CGI.pm line 41
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x77f6a8)') called at /home/trunk.foswiki.org/core/bin/view line 29.

-- MichaelTempest - 21 Feb 2012

Crawford - Is this one fixable for 1.2, or should we revert / defer to 2.0?

-- GeorgeClark - 23 Feb 2012

Fixable. Working on it.

-- CrawfordCurrie - 23 Feb 2012

After an IRC discussion I've decided to withdraw this. See the feature request.

-- CrawfordCurrie - 25 Feb 2012
 
Topic revision: r17 - 25 Feb 2012, CrawfordCurrie - This page was cached on 04 Jun 2020 - 16:22.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy