Foswiki on GitHub is open for business! Next release meeting: Monday October 13, 1300Z

Item10022: Upgrading multiple extensions only performs first action

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Urgent Closed Engine Configure  
Configure extensions installer: When checking multiple extensions, only the first action gets performed. So instead of upgrading 4 extensions, only the first one gets upgraded.

-- ArthurClemens - 14 Nov 2010

This isn't good. I've somehow broken this in passing the actions through the password screen. The submit from the extension finder passes in multiple instances of the parameter: (from Firebug:)
Parts        multipart/form-data
time   
processExt   all
action       ManageExtensions
add          Foswiki.org/ToolTipPlugin
add          Foswiki.org/VotePlugin

However the post entered from the password screen only passes through a single instance of the parameter.
Parts        multipart/form-data
time         1289785637
time   
processExt   all
action       ManageExtensions
add          Foswiki.org/ToolTipPlugin
cfgAccess    asdfaqwer

I expect it's a template issue, but I'm not sure yet how to pass multiple instances of the parameter through the form.

The template / form has:
    <#if params??>${params}</#if>

This should be populated by all of the parameters in the query, using the Foswiki query object to return the params.

Debug prints stateements added to lib/Foswiki/Configure/UIs/AUTH.pm seems to show that duplicate parms are not returned. This is a deeper issue in the Foswiki request object.

-- GeorgeClark - 15 Nov 2010

Thanks to Sven, issue is in Configure/UIs/AUTH.pm where it uses a scalar to return each parameter. Needs to use an array to process multiple value params. See http://search.cpan.org/~lds/CGI.pm-3.50/lib/CGI.pm#FETCHING_THE_VALUE_OR_VALUES_OF_A_SINGLE_NAMED_PARAMETER:

-- GeorgeClark - 15 Nov 2010
 

ItemTemplate edit

Summary Upgrading multiple extensions only performs first action
ReportedBy ArthurClemens
Codebase 1.1.2, trunk
SVN Range
AppliesTo Engine
Component Configure
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:118e31b34d8b distro:cfc9e15bb88c
TargetRelease patch
ReleasedIn 1.1.3
Topic revision: r7 - 16 Apr 2011, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License