Item5494: exit value is inverted

Priority: Normal
Current State: No Action Required
Released In: n/a
Target Release: n/a

Applies To: Extension
Component: UploadToTWikiAddOn
Branches:

Reported By: TWiki:Main.DiabJerius
Waiting For:
Last Change By: GeorgeClark

The error code returned after uploadtotwiki exits is inverted (as far as the shell is concerned): it returns 1 upon success, 0 upon failure.

The exit code is derived from the return of uploadFile ():

 exit uploadFile( $comment, $hide, $link, $delay, $url, @files );

which returns an appropriately Perlish result (1 for success, 0 for failure). This change

  exit !uploadFile( $comment, $hide, $link, $delay, $url, @files );

resolves the problem.