Item14488: PatternSkin is missing "body" zone used by NatSkin and many extensions

pencil
Priority: Enhancement
Current State: Closed
Released In: 2.1.5
Target Release: patch
Applies To: Extension
Component: FoswikiTemplates, PatternSkin
Branches: Release02x01 master Item14288 Item14454
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
NatSkin added a body zone which can be used by templates to add content at the end of the page.

Plugins designed for NatSkin don't work on PatternSkin because of the missing zone.

diff --git a/PatternSkin/templates/foswiki.pattern.tmpl b/PatternSkin/templates/foswiki.pattern.tmpl
index c3d6384..ce5a0ca 100644
--- a/PatternSkin/templates/foswiki.pattern.tmpl
+++ b/PatternSkin/templates/foswiki.pattern.tmpl
@@ -78,6 +78,6 @@
 </div>
 </div>%TMPL:END%
 
-%TMPL:DEF{"bodyend"}%</body></html>%TMPL:END%
+%TMPL:DEF{"bodyend"}%%RENDERZONE{"body"}%</body></html>%TMPL:END%
 
 %TMPL:DEF{"textareabuttons"}%<span class="foswikiRight foswikiMakeVisible" style="text-align:left; margin:0 0 0 1em;"><span class="foswikiLeft patternTextareaButton patternButtonFontSelector" title="%MAKETEXT{"Switch to monotype or proportional font"}%">&nbsp;</span><span class="foswikiLeft patternTextareaButton patternButtonEnlarge" title="%MAKETEXT{"Enlarge edit box"}%">&nbsp;</span><span class="foswikiLeft patternTextareaButton patternButtonShrink" title="%MAKETEXT{"Shrink edit box"}%">&nbsp;</span></span>%TMPL:END%
diff --git a/core/templates/foswiki.tmpl b/core/templates/foswiki.tmpl
index 5a927a6..319eb5d 100644
--- a/core/templates/foswiki.tmpl
+++ b/core/templates/foswiki.tmpl
@@ -72,6 +72,7 @@ but may be used in derived templates.
 #PageTop %TMPL:END%%{
 ---------------------------------------------------
 }%%TMPL:DEF{"bodyend"}%</div>
+%RENDERZONE{"body"}%
 </body></html>%TMPL:END%%{
 ---------------------------------------------------
 }%%TMPL:DEF{"broadcastmessage"}%%IF{"defined FOSWIKI_BROADCAST and $FOSWIKI_BROADCAST != ''" then="$percntTMPL:P{$quotbroadcastmessage:system$quot}$percnt"}%%IF{"defined BROADCASTMESSAGE and $BROADCASTMESSAGE != ''" then="$percntTMPL:P{$quotbroadcastmessage:contents$quot}$percnt"}%%TMPL:END%%{

-- GeorgeClark - 18 Sep 2017

Hi is this the reason because in a new foswiki installation, the "patternTextareaButton" and "patternButtonEnlarge" dont appear in the raw edit mode?

-- MachsGut - 21 Nov 2017

No, the controls on the raw textarea were removed during the development of the new Nat editor. The EDITBOXSIZE and EDITBOXSTYLE controls were also removed.

-- GeorgeClark - 21 Nov 2017
 
Topic revision: r8 - 22 Jan 2018, GeorgeClark - This page was cached on 25 Feb 2018 - 06:30.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License