Item14323: Update to latest TinyMCE version

pencil
Priority: Urgent
Current State: Waiting for Release
Released In: 2.2.0
Target Release: minor
Applies To: Extension
Component: TinyMCEPlugin
Branches: Item14323 master Item14288
Reported By: CrawfordCurrie
Waiting For:
Last Change By: GeorgeClark
Because there was a major change in the TinyMCE APIs many versions ago, the version we use and ship has fallen well behind the curve. We need to update to a recent version of TinyMCE, and resolve any problems that creates.

This needs to be done before any other bugs are fixed, as fixing bugs against the old version is pretty pointless.

The plan is to throw out the current hacked version and build against a production, out of the box, pre-minimised TMCE that we simply drop into the plugin, without any customisation. All customisation should be done in the Foswiki plugins (TMCE plugins, jquery plugin and FW plugin). To do that I propose to add a full TMCE developer pack alongside the production version for dev (but not ship it).

Early issues noted are:
  • the dropping of the advanced theme that we have been using. This can hopefully be replaced with modern.
  • change to the TMCE init sequence which means the point at which we build the format menus is now before TMCE has initiated the formatter (so null pointer)

-- CrawfordCurrie - 21 Feb 2017

See also Item14288, which promises to create a common framework for plugging in editors with a shared toolbar. This framework should be able to feed directly off work done here.

-- Main.CrawfordCurrie - 21 Feb 2017 - 20:46

Reckon this is good to go now. Currently on branch Item14323, waiting for merge when end user testing is complete.

-- Main.CrawfordCurrie - 22 Mar 2017 - 20:13

Crawford, Here's the failing tests and results from git bisect
05fd01581b1d685ed063d8e2474718497e0c93b8 is the first bad commit
commit 05fd01581b1d685ed063d8e2474718497e0c93b8
Author: cdot <git@c-dot.co.uk>
Date:   Fri Mar 10 13:37:13 2017 +0000

    Item14323: convert unbulleted lists to a list type instead of a div. This uses some new classes which require a core change, so the fix won't be complete until that core change is made. However it should work even without the core change (it's a display problem only)

:040000 040000 cc7cadb8ea0c383e52c27c89e0a2f2667f2c3831 8d16f567d3beff2a21f95a0f87e8b3ae8dc425b0 M      WysiwygPlugin
And the failing tests:
----------------------------
---++ Module Failure summary
TranslatorTests has 2 unexpected results (of 2):
   * F: TranslatorTests::testTML2HTML_stickyInsideLiteral
   * F: TranslatorTests::testTML2HTML_verbatimInsideLiteralItem1980
----------------------------

-- GeorgeClark - 26 Mar 2017

The tests were wrong, probably reflecting a problem in the core rendering which has since been fixed.

-- Main.CrawfordCurrie - 26 Mar 2017 - 09:52

Reopening this. the TinyMCEPlugin topic needs updates.
  • Lists of known issues needs cleanup
  • Claims it is shipipng version 3.5.7
  • Missing task entries from history.
    • Foswikitask:Item14323: Update to latest TinyMCE version
  • Render errors in the Default Plugins list - errors about missing sections in INCLUDE statements.
  • pub/System/TinyMCEPlugin/plugins/foswiki/img/colour.gif missing from MANIFEST

-- GeorgeClark - 20 Apr 2017

Reopening to get the latest version. Was 4.5.3, now (as of 30 Aug 2017 - Version 4.6.6)

-- GeorgeClark - 15 Sep 2017
 

ItemTemplate edit

Summary Update to latest TinyMCE version
ReportedBy CrawfordCurrie
Codebase trunk
SVN Range
AppliesTo Extension
Component TinyMCEPlugin
Priority Urgent
CurrentState Waiting for Release
WaitingFor
Checkins distro:fbab4877543d distro:56ffcde92b02 distro:20bc621767b8 distro:65ab19832f79 distro:a963954def96 distro:7fed6fd88788 distro:4d0def21c468 distro:2c339532fd1d distro:0fa175a5dbdc distro:9a8899666b69 distro:05fd01581b1d distro:03ba3dd9cc38 distro:51c1da7a4ca1 distro:d557f6cc4ec8 distro:ef75b01c5a60 distro:326a4f78c6df distro:97bc5a169a66 distro:2cb7414f3560 distro:0d5df86dc10a distro:a1c0f9d690cd distro:3e9f29f4fea8 distro:9545182ececc distro:9205ace6ba05 distro:547b55582b6e
TargetRelease minor
ReleasedIn 2.2.0
CheckinsOnBranches Item14323 master Item14288
trunkCheckins
masterCheckins distro:fbab4877543d distro:56ffcde92b02 distro:20bc621767b8 distro:65ab19832f79 distro:a963954def96 distro:7fed6fd88788 distro:4d0def21c468 distro:2c339532fd1d distro:0fa175a5dbdc distro:9a8899666b69 distro:05fd01581b1d distro:03ba3dd9cc38 distro:51c1da7a4ca1 distro:d557f6cc4ec8 distro:ef75b01c5a60 distro:326a4f78c6df distro:97bc5a169a66 distro:2cb7414f3560 distro:0d5df86dc10a distro:a1c0f9d690cd distro:3e9f29f4fea8 distro:9545182ececc distro:9205ace6ba05 distro:547b55582b6e
ItemBranchCheckins distro:fbab4877543d distro:56ffcde92b02 distro:20bc621767b8 distro:65ab19832f79 distro:a963954def96 distro:7fed6fd88788 distro:4d0def21c468 distro:2c339532fd1d distro:0fa175a5dbdc distro:9a8899666b69 distro:05fd01581b1d distro:03ba3dd9cc38 distro:51c1da7a4ca1 distro:d557f6cc4ec8 distro:ef75b01c5a60 distro:326a4f78c6df distro:97bc5a169a66 distro:2cb7414f3560 distro:0d5df86dc10a distro:a1c0f9d690cd distro:3e9f29f4fea8 distro:9545182ececc distro:9205ace6ba05 distro:547b55582b6e
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins
Topic revision: r24 - 18 Sep 2017, GeorgeClark - This page was cached on 23 Sep 2017 - 07:54.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License