Item14234: Clicking pencil for first row (erp_row=0) opens editor on entire table.

pencil
Priority: Normal
Current State: Closed
Released In: 2.1.4
Target Release: patch
Applies To: Extension
Component: EditRowPlugin
Branches: Release02x01 master Item14288
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
row 1
row 1
Row 2
Row 2b

-- GeorgeClark - 26 Nov 2016

This patch seems to resolve the issue:
diff --git a/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Table.pm b/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Table.pm
index 2d6629e..daed50a 100644
--- a/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Table.pm
+++ b/EditRowPlugin/lib/Foswiki/Plugins/EditRowPlugin/Table.pm
@@ -177,7 +177,7 @@ sub render {
 
     my $editing = ( $opts->{for_edit} && $this->can_edit() );
     my $wholeTable =
-      ( defined $opts->{active_row} && $opts->{active_row} <= 0 );
+      ( defined $opts->{active_row} && $opts->{active_row} < 0 );
 
     my $id = $this->getID();
     push( @out, Foswiki::Render::html( 'a', { name => "erp_${id}" } ) )

-- GeorgeClark - 07 May 2017
 
Topic revision: r6 - 01 Jun 2017, GeorgeClark - This page was cached on 26 Sep 2017 - 22:45.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License