You are here: Foswiki>Tasks Web>Item13957 (11 Aug 2016, GeorgeClark)Edit Attach

Item13957: TinyMCEPlugin does not handle indent correctly.

pencil
Priority: Urgent
Current State: Closed
Released In: 2.1.1
Target Release: patch
Applies To: Extension
Component: TinyMCEPlugin
Branches: master Release02x01 Item13989 Item14033 Item13897
Reported By: KennethLavrsen
Waiting For: CrawfordCurrie, KennethLavrsen
Last Change By: GeorgeClark
I have been playing with the new indent feature

Overall it looks good and people will love it.

But there is a significant problem

If you start writing indented text in the Wysiwyg mode and you click enter to get a new line, it does create new lines indented just fine. But if I want to have a paragraph space with a white space line and create a blank line even without the leading : and continue writing indented text the blank line is eaten and the two indented sections merged to one.

Even if I write some indented text line this in Edit Wikitext

   : Indented line 1
   : Indented line 2 next line is blank

   : New indent after blank line
   : last indent

I get a fine paragraph space.

When I then edit and save in Wysiwyg mode the editor eats the empty line.

I will open one more bug item on the indent rendering and the two may be connected.

-- KennethLavrsen - 11 Feb 2016

I've fixed this, however is causes some white space growth. Not quite sure how to resolve both issues. Needs some review.
BeforeAfter
   : Indent 1
      : Indent 2
New paragraph without indent
   : Indent 1
      : Indent 2

New paragraph without indent

I believe that it's relatively inconsequential because ending a : block should start a new paragraph, which is represented by a blank line in TML. -- GeorgeClark - 19 Mar 2016

Sorry it took so long. I had trouble getting my git to work and had to do a new check out.

I think it works pretty well. I have not found any negative consequences of the fix

The "growth" is not an uncontrolled growth that keeps on adding blanks lines (like in previous bugs). It is added and then it remains like this even if you edit and save again. And it did the same before your fix.

At least the indent feature works now in the Wysiwyg editor. I will set this to Waiting For Release

-- KennethLavrsen - 30 Mar 2016
 
Topic revision: r9 - 11 Aug 2016, GeorgeClark - This page was cached on 29 Mar 2017 - 15:13.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License