You are here: Foswiki>Tasks Web>Component>Store>Item13894 (20 Mar 2016, GeorgeClark)Edit Attach

Item13894: RcsStore double-encodes utf8 comments into the attachment revision log.

Priority: Normal
Current State: Closed
Released In: 2.1.0
Target Release: minor

Applies To: Extension
Component:
Branches: master Release02x00

Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark

~~Removing a call to _encode($comment) appears to fix the attachment comment history.~~

-- GeorgeClark - 14 Dec 2015

Thought I fixed it locally ... but still failing on trunk.foswiki.org.

Re-creation:

Attach a file, with unicode text in the comment
The comment is correct in the Meta, but wrong in the attachment history

-- GeorgeClark - 14 Dec 2015

Reverted. Fix was incorrect, and I have no idea what/where the fix is.

-- GeorgeClark - 14 Dec 2015

Would this happen to be related to a fancy behaviour we are seeing with /bin/rest/ImagePlugin/resize. The supposed JPG binary data gets utf8 encoded!

-- Main.AndreLichtsteiner - 14 Dec 2015 - 14:01

ItemTemplate edit

Summary	RcsStore double-encodes utf8 comments into the attachment revision log.
ReportedBy	GeorgeClark
Codebase	2.0.3, 2.0.2, 2.0.1, 2.0.0, trunk
SVN Range
AppliesTo	Extension
Component
Priority	Normal
CurrentState	Closed
WaitingFor
Checkins	distro:35aeb6f5b498 distro:7269bb78835d distro:dcf8bc67c83d distro:cdd6149803a0 distro:a81649b81f2e distro:6180f098c88f
TargetRelease	minor
ReleasedIn	2.1.0
CheckinsOnBranches	master Release02x00
trunkCheckins
masterCheckins	distro:35aeb6f5b498 distro:dcf8bc67c83d distro:a81649b81f2e
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins	distro:7269bb78835d distro:cdd6149803a0 distro:6180f098c88f
Release01x01Checkins