You are here: Foswiki>Tasks Web>Item13855 (15 Dec 2015, GeorgeClark)Edit Attach

Item13855: Foswiki 1.1.10 Unit Test Failures

pencil
Priority: Normal
Current State: No Action Required
Released In: 1.1.10
Target Release: patch
Applies To: Extension
Component: CommentPlugin, TablePlugin
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
There are several unit test failures that are blocking a final 1.1 release - 1.1.10.

TablePlugin

I suspect that these failures are a test issue, and not real failures. The test appears to get \x00 instead of   in the HTML being compared. I don't observe the issue on a live 1.1.10 system, only the test fails.

Module Failure summary

TablePluginTests has 2 unexpected results (of 26): 
        TablePluginTests::test_sort_numbers__mixed
*** 
TablePlugin/TablePluginTests.pm:44
######################################## Got as result:
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<table class="foswikiTable" border="1" rules="none" id="tableTestTopicTableFormatting1">
        <thead>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <th class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> <a href="/foswiki/bin//TemporaryTableFormattingTestWebTableFormatting/TestTopicTableFormatting?sortcol=0;table=1;up=1#sorted_table" title="Sort by this column" rel="nofollow">Mostly numbers</a><span class="tableSortIcon tableSortUp"><img title="Sorted ascending" border="0" height="13" width="11" alt="Sorted ascending" src="/foswiki/pub/System/DocumentGraphics/tablesortup.gif" /></span> </th>
                </tr>
        </thead>
        <tbody>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> &nbsp; </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> -1 </td>
                </tr>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> 0 </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol" rowspan="1"> 1 </td>
                </tr>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> 3 </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol foswikiLast"> ls -al </td>
                </tr>
        </tbody></table>
######################################## (end of result)
######################################## But expected html equal string:
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<nop>
<table id="tableTestTopicTableFormatting1" class="foswikiTable" rules="none" border="1">
        <thead>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <th class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> <a rel="nofollow" href="/foswiki/bin//TemporaryTableFormattingTestWebTableFormatting/TestTopicTableFormatting?sortcol=0;table=1;up=1#sorted_table" title="Sort by this column">Mostly numbers</a><span class="tableSortIcon tableSortUp"><img width="11" alt="Sorted ascending" src="/foswiki/pub/System/DocumentGraphics/tablesortup.gif" title="Sorted ascending" height="13" border="0" /></span> </th>
                </tr>
        </thead>
        <tbody>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol">  </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> -1 </td>
                </tr>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> 0 </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> 1 </td>
                </tr>
                <tr class="foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol"> 3 </td>
                </tr>
                <tr class="foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1">
                        <td rowspan="1" class="foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol foswikiLast"> ls -al </td>
                </tr>
        </tbody></table>

######################################## (end of expected)
######################################## Diff:
<nop> <nop> <nop> <nop> <nop> <nop> <nop> <nop> <table border=1 class=foswikiTable id=tableTestTopicTableFormatting1 rules=none> <thead> <tr class=foswikiTableOdd foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0> <th class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol> <a href=/foswiki/bin//TemporaryTableFormattingTestWebTableFormatting/TestTopicTableFormatting?sortcol=0;table=1;up=1#sorted_table rel=nofollow title=Sort by this column> Mostly numbers </a> <span class=tableSortIcon tableSortUp> <img alt=Sorted ascending border=0 height=13 src=/foswiki/pub/System/DocumentGraphics/tablesortup.gif title=Sorted ascending width=11> </img> </span> </th> </tr> </thead> <tbody> <tr class=foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol rowspan=1> 
- 
+ �
</td> </tr> <tr class=foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol rowspan=1> -1 </td> </tr> <tr class=foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol rowspan=1>  </td> </tr> <tr class=foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol rowspan=1> 1 </td> </tr> <tr class=foswikiTableEven foswikiTableRowdataBgSorted0 foswikiTableRowdataBg0> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol rowspan=1> 3 </td> </tr> <tr class=foswikiTableOdd foswikiTableRowdataBgSorted1 foswikiTableRowdataBg1> <td class=foswikiTableCol0 foswikiSortedAscendingCol foswikiSortedCol foswikiFirstCol foswikiLastCol foswikiLast rowspan=1> ls -al </td> </tr> </tbody> </table> 
######################################## (end diff)
 at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 554.
        Unit::TestCase::assert_html_equals(TablePluginTests=HASH(0x2899f30), "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table id=\"ta"..., "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table class="...) called at TablePlugin/TablePluginTests.pm line 44
        TablePluginTests::do_test(TablePluginTests=HASH(0x2899f30), "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table id=\"ta"..., "%TABLE{sort=\"on\" initsort=\"1\"}%\x{a}| *Mostly numbers* |\x{a}| -1 |\x{a}|"...) called at TablePlugin/TablePluginTests.pm line 722
        TablePluginTests::test_sort_numbers__mixed(TablePluginTests=HASH(0x2899f30)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x4924408), HASH(0x4999518)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x28456c0), TablePluginTests=HASH(0x2899f30), "TablePluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x28456c0), "TablePlugin") called at ../bin/TestRunner.pl line 132
 at /var/www/foswiki/distro/core/test/unit/FoswikiTestCase.pm line 45.
        FoswikiTestCase::__ANON__("\x{a}TablePlugin/TablePluginTests.pm:44\x{a}#########################"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 226
        Unit::TestCase::assert(TablePluginTests=HASH(0x2899f30), 0, "TablePlugin/TablePluginTests.pm:44\x{a}##########################"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 554
        Unit::TestCase::assert_html_equals(TablePluginTests=HASH(0x2899f30), "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table id=\"ta"..., "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table class="...) called at TablePlugin/TablePluginTests.pm line 44
        TablePluginTests::do_test(TablePluginTests=HASH(0x2899f30), "<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<nop>\x{a}<table id=\"ta"..., "%TABLE{sort=\"on\" initsort=\"1\"}%\x{a}| *Mostly numbers* |\x{a}| -1 |\x{a}|"...) called at TablePlugin/TablePluginTests.pm line 722
        TablePluginTests::test_sort_numbers__mixed(TablePluginTests=HASH(0x2899f30)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x4924408), HASH(0x4999518)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x28456c0), TablePluginTests=HASH(0x2899f30), "TablePluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x28456c0), "TablePlugin") called

        TablePluginTests::test_simpleTfootTableUsingTablePlugin
        TablePluginTests::test_sort_off_initsort_invalid_col
        TablePluginTests::test_sort_numbers_with_strings_mixed
***

CommentPlugin

This one is a bit more concerning, as it impacts redirecting after comments, and the ACL checking of comment operations. This is what's holding up the release.

Module Failure summary

CommentPluginTests has 6 unexpected results (of 39): 
Running CommentPluginTests
        CommentPluginTests::test_comment_encoding_guest
*** 
Expected:'(?^:Status: 302)'
 But got:'Content-Type: text/html; charset=ISO-8859-1
Status: 200
Set-Cookie: FOSWIKISID=f9135d26348964760bc76ce56c9b96ec; path=/; HttpOnly

'
 at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366.
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(Status: 302), "Content-Type: text/html; charset=ISO-8859-1\x{d}\x{a}Status: 200\x{d}\x{a}Set"...) called at CommentPlugin/CommentPluginTests.pm line 1032
        CommentPluginTests::test_comment_encoding_guest(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x308eca0), HASH(0x338dd60)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called at ../bin/TestRunner.pl line 132
 at /var/www/foswiki/distro/core/test/unit/FoswikiTestCase.pm line 45.
        FoswikiTestCase::__ANON__("\x{a}Expected:'(?^:Status: 302)'\x{a} But got:'Content-Type: text/htm"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 226
        Unit::TestCase::assert(CommentPluginTests=HASH(0x1819de8), "", "Expected:'(?^:Status: 302)'\x{a} But got:'Content-Type: text/html"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(Status: 302), "Content-Type: text/html; charset=ISO-8859-1\x{d}\x{a}Status: 200\x{d}\x{a}Set"...) called at CommentPlugin/CommentPluginTests.pm line 1032
        CommentPluginTests::test_comment_encoding_guest(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x308eca0), HASH(0x338dd60)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called

        CommentPluginTests::test_reverseCompat
        CommentPluginTests::test_comment_encoding_notguest
*** 
Expected:'(?^:Status: 302)'
 But got:'Content-Type: text/html; charset=ISO-8859-1
Status: 200
Set-Cookie: FOSWIKISID=328f0f81838ff1fa78c3de9ad4225a21; path=/; HttpOnly

'
 at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366.
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(Status: 302), "Content-Type: text/html; charset=ISO-8859-1\x{d}\x{a}Status: 200\x{d}\x{a}Set"...) called at CommentPlugin/CommentPluginTests.pm line 971
        CommentPluginTests::test_comment_encoding_notguest(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x183f4e0), HASH(0x3667de0)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called at ../bin/TestRunner.pl line 132
 at /var/www/foswiki/distro/core/test/unit/FoswikiTestCase.pm line 45.
        FoswikiTestCase::__ANON__("\x{a}Expected:'(?^:Status: 302)'\x{a} But got:'Content-Type: text/htm"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 226
        Unit::TestCase::assert(CommentPluginTests=HASH(0x1819de8), "", "Expected:'(?^:Status: 302)'\x{a} But got:'Content-Type: text/html"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(Status: 302), "Content-Type: text/html; charset=ISO-8859-1\x{d}\x{a}Status: 200\x{d}\x{a}Set"...) called at CommentPlugin/CommentPluginTests.pm line 971
        CommentPluginTests::test_comment_encoding_notguest(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x183f4e0), HASH(0x3667de0)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called

        CommentPluginTests::verify_targetWebTopicAboveAnchor_Missing_Item727_viewContext
        CommentPluginTests::verify_acl_COMMENT_viewContext
*** AccessControlException: Access to CHANGE TemporaryCommentPluginTestsTestWebCommentPluginTests.TestTopicCommentPluginTests for ScumBag is denied. Comment on topic not permitted
        CommentPluginTests::verify_location_viewContext
        CommentPluginTests::verify_LocationRE_viewContext
        CommentPluginTests::verify_remove_viewContext
        CommentPluginTests::verify_nopost_viewContext
        CommentPluginTests::verify_rev1_template_redirectto_viewContext
*** 
Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginTests/TestTopicCommentPluginTests\?tab=discuss)'
 But got:'Set-Cookie: FOSWIKISID=72434400fec7d23aaee966a0649bd0be; path=/; HttpOnly
Content-Type: text/html; charset=ISO-8859-1
Status: 200

'
 at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366.
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginT)...ms, "Set-Cookie: FOSWIKISID=72434400fec7d23aaee966a0649bd0be; path"...) called at CommentPlugin/CommentPluginTests.pm line 920
        CommentPluginTests::verify_rev1_template_redirectto(CommentPluginTests=HASH(0x1819de8)) called at (eval 50) line 4
        Unit::TestCase::__ANON__(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x369aad0), HASH(0x377ca20)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called at ../bin/TestRunner.pl line 132
 at /var/www/foswiki/distro/core/test/unit/FoswikiTestCase.pm line 45.
        FoswikiTestCase::__ANON__("\x{a}Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTest"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 226
        Unit::TestCase::assert(CommentPluginTests=HASH(0x1819de8), "", "Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTestW"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginT)...ms, "Set-Cookie: FOSWIKISID=72434400fec7d23aaee966a0649bd0be; path"...) called at CommentPlugin/CommentPluginTests.pm line 920
        CommentPluginTests::verify_rev1_template_redirectto(CommentPluginTests=HASH(0x1819de8)) called at (eval 50) line 4
        Unit::TestCase::__ANON__(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x369aad0), HASH(0x377ca20)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called

        CommentPluginTests::verify_targetWebTopic_viewContext
        CommentPluginTests::verify_targetWebTopicAnchorBottom_viewContext
        CommentPluginTests::verify_above_viewContext
        CommentPluginTests::verify_rest_control_modes_viewContext
        CommentPluginTests::verify_targetTopic_viewContext
        CommentPluginTests::verify_targetWebTopicBelowAnchor_Missing_Item727_viewContext
        CommentPluginTests::verify_redirectto_redirects_viewContext
        CommentPluginTests::verify_below_viewContext
        CommentPluginTests::verify_targetWebTopicAnchorTop_viewContext
        CommentPluginTests::verify_default_viewContext
        CommentPluginTests::verify_locationOverridesAnchor_viewContext
        CommentPluginTests::verify_targetWebTopicAboveAnchor_Missing_Item727_staticContext
        CommentPluginTests::verify_acl_COMMENT_staticContext
*** AccessControlException: Access to CHANGE TemporaryCommentPluginTestsTestWebCommentPluginTests.TestTopicCommentPluginTests for ScumBag is denied. Comment on topic not permitted
        CommentPluginTests::verify_location_staticContext
        CommentPluginTests::verify_LocationRE_staticContext
        CommentPluginTests::verify_remove_staticContext
        CommentPluginTests::verify_nopost_staticContext
        CommentPluginTests::verify_rev1_template_redirectto_staticContext
*** 
Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginTests/TestTopicCommentPluginTests\?tab=discuss)'
 But got:'Set-Cookie: FOSWIKISID=d58232076154bdad748aa8b218b7e27e; path=/; HttpOnly
Status: 200
Content-Type: text/html; charset=ISO-8859-1

'
 at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366.
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginT)...ms, "Set-Cookie: FOSWIKISID=d58232076154bdad748aa8b218b7e27e; path"...) called at CommentPlugin/CommentPluginTests.pm line 920
        CommentPluginTests::verify_rev1_template_redirectto(CommentPluginTests=HASH(0x1819de8)) called at (eval 68) line 4
        Unit::TestCase::__ANON__(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x39cddc8), HASH(0x3a10ef0)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called at ../bin/TestRunner.pl line 132
 at /var/www/foswiki/distro/core/test/unit/FoswikiTestCase.pm line 45.
        FoswikiTestCase::__ANON__("\x{a}Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTest"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 226
        Unit::TestCase::assert(CommentPluginTests=HASH(0x1819de8), "", "Expected:'(?^ms:^Location:.*/TemporaryCommentPluginTestsTestW"...) called at /var/www/foswiki/distro/core/lib/Unit/TestCase.pm line 366
        Unit::TestCase::assert_matches(CommentPluginTests=HASH(0x1819de8), qr(^Location:.*/TemporaryCommentPluginTestsTestWebCommentPluginT)...ms, "Set-Cookie: FOSWIKISID=d58232076154bdad748aa8b218b7e27e; path"...) called at CommentPlugin/CommentPluginTests.pm line 920
        CommentPluginTests::verify_rev1_template_redirectto(CommentPluginTests=HASH(0x1819de8)) called at (eval 68) line 4
        Unit::TestCase::__ANON__(CommentPluginTests=HASH(0x1819de8)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 567
        Unit::TestRunner::__ANON__() called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 379
        eval {...} called at /var/www/foswiki/distro/core/lib/CPAN/lib/Error.pm line 371
        Error::subs::try(CODE(0x39cddc8), HASH(0x3a10ef0)) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 594
        Unit::TestRunner::runOne(Unit::TestRunner=HASH(0x17c56d0), CommentPluginTests=HASH(0x1819de8), "CommentPluginTests", undef) called at /var/www/foswiki/distro/core/lib/Unit/TestRunner.pm line 157
        Unit::TestRunner::start(Unit::TestRunner=HASH(0x17c56d0), "CommentPlugin") called

        CommentPluginTests::verify_targetWebTopic_staticContext
        CommentPluginTests::verify_targetWebTopicAnchorBottom_staticContext
        CommentPluginTests::verify_above_staticContext
        CommentPluginTests::verify_rest_control_modes_staticContext
        CommentPluginTests::verify_targetTopic_staticContext
        CommentPluginTests::verify_targetWebTopicBelowAnchor_Missing_Item727_staticContext
        CommentPluginTests::verify_redirectto_redirects_staticContext
        CommentPluginTests::verify_below_staticContext
        CommentPluginTests::verify_targetWebTopicAnchorTop_staticContext
        CommentPluginTests::verify_default_staticContext
        CommentPluginTests::verify_locationOverridesAnchor_staticContext

-- GeorgeClark - 17 Nov 2015

Discussed on IRC last night. The problem is a difference in the way REST is handled which is not reflected in the tests. A 302 or a 200 may be returned by REST. The tests need updating (patch attached)

-- Main.CrawfordCurrie - 20 Nov 2015 - 09:30

Setting to No Action.

-- GeorgeClark - 15 Dec 2015
 

ItemTemplate edit

Summary Foswiki 1.1.10 Unit Test Failures
ReportedBy GeorgeClark
Codebase
SVN Range
AppliesTo Extension
Component CommentPlugin, TablePlugin
Priority Normal
CurrentState No Action Required
WaitingFor
Checkins
TargetRelease patch
ReleasedIn 1.1.10
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x00Checkins
Release01x01Checkins
I Attachment Action Size Date Who Comment
patchEXT patch manage 1 K 20 Nov 2015 - 09:34 CrawfordCurrie Add support for 200 status in REST returns
Edit  | Attach | Print version | History: r3 < r2 < r1 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r3 - 15 Dec 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy