Item13328: Configure lose ends: Checkers that have orphaned code, or perform bootstrap functions.

WorkingDir checker orphan code to migrate / create the WorkingDir. Need to decide what to do with this?

- Move to bootstrap? - Discard ... and recommend 1.2 is a "reinstall"? - Move to a onSave for when the value is committed to the config?

See: https://github.com/foswiki/distro/blob/master/core/lib/Foswiki/Configure/Checkers/WorkingDir.pm#L34

-- GeorgeClark - 25 Mar 2015

Log/Dir.pm checker migrates the config file settings See https://github.com/foswiki/distro/blob/master/core/lib/Foswiki/Configure/Checkers/Log/Dir.pm#L44

Needs to be moved into the Load.pm mapping functions.

-- GeorgeClark - 26 Mar 2015

Site/CharSet.pm "bootstraps" the setting from the Locale. This needs to either moved into bootstrap, or changed to onSave handler. Same with Site/Locale.pm. It bootstraps itself.

-- GeorgeClark - 26 Mar 2015

As you know, checkers should never ever be "migrating" or "creating". Checkers check. That's all they do. Any rewriting of the configuration, or modifying the install, must be done from a wizard (or from the bootstrap).

I really don't think an onSave should be modifying the configuration on the fly either, though this may be required on a case-by-case basis.

There may be a case for a "repair" or "migrate" phase after bootstrap that handles these special cases, but I'm slightly concerned that might create more confusion than it solves :-/

-- CrawfordCurrie - 26 Mar 2015

A fix for Locale / CharSet / bootstrap is checked in. In one case I had to override {Site}{CharSet} but that's to prevent a crash. If it's set incorrectly Foswiki:Response is unable to get the error messages back to the UI. needs careful testing. At least locally I'm getting usable, but different results when running on Apache vs. cli.

-- GeorgeClark - 27 Mar 2015

Commenting is disabled while not logged in