You are here: Foswiki>Tasks Web>Item12913 (02 Jan 2015, GeorgeClark)Edit Attach

Item12913: Trunk manifest issues - files missing from manifest, check_manifest is not complete.

pencil
Priority: Normal
Current State: Closed
Released In: 1.2.0
Target Release: minor
Applies To: Engine
Component: BuildContrib
Branches: trunk master
Reported By: GeorgeClark
Waiting For:
Last Change By: GeorgeClark
Ran the check_manifest script and found a number of manifest inconsistencies. Some I've fixed, but others I'm not sure what to do with.

Also the check_manifest script has some issues. It doesn't do a recursive check when checking core. And it seems to occasionally incorrectly flag files. (It flags files as missing from manifest if the permissions are not present).

-- GeorgeClark - 24 May 2014

SmiliesPlugin

Except for the Makefile, I think that these are obsolete and can be rm'd from the repo. 
Processing manifest /var/www/foswiki/trunk/SmiliesPlugin/lib/Foswiki/Plugins/SmiliesPlugin/MANIFEST
The following 21 files files were found in git, but are not in MANIFEST:
pub/System/SmiliesPlugin/Makefile
pub/System/SmiliesPlugin/biggrin.gif
pub/System/SmiliesPlugin/confused.gif
pub/System/SmiliesPlugin/cool.gif
pub/System/SmiliesPlugin/devil.gif
pub/System/SmiliesPlugin/devilwink.gif
pub/System/SmiliesPlugin/eek.gif
pub/System/SmiliesPlugin/frown.gif
pub/System/SmiliesPlugin/indifferent.gif
pub/System/SmiliesPlugin/love.gif
pub/System/SmiliesPlugin/mad.gif
pub/System/SmiliesPlugin/no.gif
pub/System/SmiliesPlugin/redface.gif
pub/System/SmiliesPlugin/rolleyes.gif
pub/System/SmiliesPlugin/sealed.gif
pub/System/SmiliesPlugin/skull.gif
pub/System/SmiliesPlugin/smile.gif
pub/System/SmiliesPlugin/thumbs.gif
pub/System/SmiliesPlugin/tongue.gif
pub/System/SmiliesPlugin/wink.gif
pub/System/SmiliesPlugin/yes.gif

-- GeorgeClark - 24 May 2014

PatternSkin

Not sure what is going on with these. They don't appear to be referenced 
Processing manifest /var/www/foswiki/trunk/PatternSkin/lib/Foswiki/Contrib/PatternSkin/MANIFEST
The following 24 files files were found in git, but are not in MANIFEST:
pub/System/PatternSkinTheme/top_bar_gradient.png
pub/System/PatternSkinTheme2012/20091227_Foswiki_logo.png
pub/System/PatternSkinTheme2012/Foswiki_logo_2011-ico.png
pub/System/PatternSkinTheme2012/Foswiki_logo_double_O.png
pub/System/PatternSkinTheme2012/Foswiki_logo_horizontal.svg
pub/System/PatternSkinTheme2012/Foswiki_logo_ico.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_100px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_150px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_200px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_300dpi.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_300px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_60px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_mark_80px.png
pub/System/PatternSkinTheme2012/Foswiki_logo_on_white.png
pub/System/PatternSkinTheme2012/Foswiki_logo_rainbow.png
pub/System/PatternSkinTheme2012/Foswiki_logo_updrop.png
pub/System/PatternSkinTheme2012/Foswiki_logo_vertical.svg
pub/System/PatternSkinTheme2012/Foswiki_logo_vertical_300dpi.png
pub/System/PatternSkinTheme2012/fw-logo-colored.png
pub/System/PatternSkinTheme2012/keepers.jpg
pub/System/PatternSkinTheme2012/logo.png
pub/System/PatternSkinTheme2012/new-foswiki-logo.svg
pub/System/PatternSkinTheme2012/new-foswiki-logo3.png
pub/System/PatternSkinTheme2012/wheel.png
All files in MANIFEST are in git.

-- GeorgeClark - 24 May 2014

JQueryPlugin

I think the ,v files should be removed from the repo. I assume the uncompressed files are okay, as we will ship the compressed versions. The manifest checker could use some tweaking. 
Processing manifest /var/www/foswiki/trunk/JQueryPlugin/lib/Foswiki/Plugins/JQueryPlugin/MANIFEST
The following 15 files files were found in git, but are not in MANIFEST:
pub/System/JQueryCycle/beach1.jpg,v
pub/System/JQueryCycle/beach2.jpg,v
pub/System/JQueryCycle/beach3.jpg,v
pub/System/JQueryInnerFade/ggbg.gif,v
pub/System/JQueryInnerFade/km.jpg,v
pub/System/JQueryInnerFade/rt_arch.jpg,v
pub/System/JQueryInnerFade/tuev.jpg,v
pub/System/JQueryInnerFade/whizzkids.gif,v
pub/System/JQueryMasonry/jQuery-Masonry.jpg,v
pub/System/JQueryPlugin/plugins/simplemodal/jquery.simplemodal-1.4.2.patch
pub/System/JQueryPlugin/plugins/tabpane/jquery.tabpane.init.uncompressed.js
pub/System/JQueryPlugin/plugins/validate/jquery.validate.1.7.uncompressed.patch
pub/System/JQueryPlugin/plugins/validate/jquery.validate.1.8.uncompressed.patch
pub/System/JQueryPlugin/plugins/validate/jquery.validate.1.9.uncompressed.patch
pub/System/JQuerySlimbox/IMG_1190.JPG,v
All files in MANIFEST are in git.

-- GeorgeClark - 24 May 2014

FamFamFamContrib

I think it's okay to omit the SVG files. They don't seem to be referenced. 

Processing manifest /var/www/foswiki/trunk/FamFamFamContrib/lib/Foswiki/Contrib/FamFamFamContrib/MANIFEST
The following 4 files files were found in git, but are not in MANIFEST:
pub/System/FamFamFamFoswikiExtras/UEB.svg
pub/System/FamFamFamFoswikiExtras/UEB_inverted.svg
pub/System/FamFamFamFoswikiExtras/XML_icon.svg
pub/System/FamFamFamSilkGeoSilkIcons/_readme.txt
All files in MANIFEST are in git.

-- GeorgeClark - 24 May 2014

  • SmiliesPlugin: these are the old smilies left in for reference; we've got a different icon set now
  • JQueryPlugin: the ,v should indeed be removed from the repo; surely, we don't ship them; the patch files are in the repo to document any local modifications to upstream
  • FamFamFamContrib: the svg files are in there for development with pngs being derived from them; the _readme.txt could go out though
  • PatternSkin: no clue

-- MichaelDaum - 26 May 2014

PatternSkin is a new theme that picks up the latest Foswiki logo. We need to decide if we are going to use it instead of the current FatWilly theme. Other than that, I think the MANIFEST looks good. Closing the task.

-- GeorgeClark - 02 Jan 2015

 

ItemTemplate edit

Summary Trunk manifest issues - files missing from manifest, check_manifest is not complete.
ReportedBy GeorgeClark
Codebase trunk
SVN Range
AppliesTo Engine
Component BuildContrib
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:14df1a3ff052 distro:35cbc3caf6bd
TargetRelease minor
ReleasedIn 1.2.0
CheckinsOnBranches trunk master
trunkCheckins distro:14df1a3ff052
masterCheckins distro:35cbc3caf6bd
ItemBranchCheckins
Release01x01Checkins
Edit  | Attach | Print version | History: r5 < r4 < r3 < r2 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r5 - 02 Jan 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy