Item1116: PatternSkinColorSettings partially working

Some of the color preferences defined on PatternSkinColorSettings are not used to generate the CSS. On top of that some colors are still hard coded in the CSS template.

See TABLE_DATA_ODD_SELECTED_BACKGROUND and TABLE_DATA_EVEN_SELECTED_BACKGROUND for instance.

I came across that bug while trying to do extensive color changes using this method.

-- StephaneLenclud - 22 Feb 2009

If preferences are not used they may get deleted.

Some colors are hardcoded:

• print screen background: always white
• button backgrounds and borders that depend on the images that are used

Table colors are set by TablePlugin settings.

Any more you found?

-- ArthurClemens - 22 Feb 2009

I'm actually making use of some of the table preferences previously unused. I've added the following to customize the tables for instance:

.foswikiTableEven td {
   background-color:%TABLE_DATA_EVEN_BACKGROUND%
}

.foswikiTableOdd td {
   background-color:%TABLE_DATA_ODD_BACKGROUND%
}

.foswikiTableOdd th,
.foswikiTableEven th {
   background-color:%TABLE_HEADER_BACKGROUND%
}


/*Selected header*/
.foswikiTableOdd th.foswikiSortedCol,
.foswikiTableEven th.foswikiSortedCol {
   background-color:%TABLE_SELECTED_COLUMN_HEADER_BACKGROUND%
}

/*Selected odd row*/
.foswikiTableOdd td.foswikiSortedCol {
background-color:%TABLE_DATA_ODD_SELECTED_BACKGROUND%
}

/*Selected even row*/
.foswikiTableEven td.foswikiSortedCol {
background-color:%TABLE_DATA_EVEN_SELECTED_BACKGROUND%
}

That work is part of JQueryLibPlugin

-- StephaneLenclud - 22 Feb 2009

What is the bug?

-- ArthurClemens - 15 Jun 2009

I also wonder. It is very important that we do not loose the ability to change table row colours using the settings in TablePlugin. We use that many places. Also per topic level.

-- KennethLavrsen - 15 Jun 2009

Sorry had no time to follow up on that. The bug's described on the first line above, however as stated it is quite generic. Still to not planning to get involved with that at the moment so: "No Action Required" I suppose.

-- StephaneLenclud - 28 Apr 2010