You are here: Foswiki>Tasks Web>Extension>CompareRevisionsAddOn>Item10495 (16 Apr 2011, KennethLavrsen)Edit Attach

Item10495: Fix compare unit tests; default Foswiki::UI topic/web missing response status should be 404, not 403.

Priority: Normal
Current State: Closed
Released In: 1.1.3
Target Release: patch

Applies To: Extension
Component: CompareRevisionsAddOn
Branches:

Reported By: PaulHarvey
Waiting For: PaulHarvey
Last Change By: KennethLavrsen

compare just calls Foswiki::UI::checkTopicExists without catching any exception. So the unit test doesn't get any HTTP/HTML back, and can't parse a response code.

Removing it from the list of verify_switchboard_function_nonExistantWeb tests.

Also, fixed Foswiki::UI's default 403 response code (should be 404 for topic/web missing).

-- PaulHarvey - 17 Mar 2011

ItemTemplate edit

Summary	Fix compare unit tests; default Foswiki::UI topic/web missing response status should be 404, not 403.
ReportedBy	PaulHarvey
Codebase	1.1.3 beta1, trunk
SVN Range
AppliesTo	Extension
Component	CompareRevisionsAddOn
Priority	Normal
CurrentState	Closed
WaitingFor	PaulHarvey
Checkins	distro:9835951aa4df distro:ad5fb7a8fca6 distro:492655d74bfb distro:4a924057802f
TargetRelease	patch
ReleasedIn	1.1.3