Item8344: TagMePlugin: Unable to allow everyone to change tags

pencil
Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: TagMePlugin
Branches: trunk
Reported By: MartinKaufmann
Waiting For:
Last Change By: FlorianSchlichting
In the documentation of TagMePlugin there is the following table about who's allowed to change tags:

Preference name Meaning Default
TAGMEPLUGIN_ALLOW_TAG_CHANGE List of users and groups that are allowed to change (rename and delete) tags (names separated by commas).
Users that are not allowed to change post their change requests to TagMeChangeRequests.
If not set anyone can change tags.
AdminGroup

The way I understand it, using the setting
   * Set TAGMEPLUGIN_ALLOW_TAG_CHANGE =
(i.e. leaving it empty) in SitePreferences should allow everyone to change tags. This doesn't seem to work on my system. I first had to change TagMePlugin.pm:

--- TagMePlugin.pm.orig 2009-06-11 18:29:57.000000000 +0200
+++ TagMePlugin.pm      2009-10-28 17:52:50.000000000 +0100
@@ -1483,8 +1483,7 @@
 sub _canChange {

     my $allowModifyPrefNames =
-      Foswiki::Func::getPluginPreferencesValue('ALLOW_TAG_CHANGE')
-      || 'AdminGroup';
+      Foswiki::Func::getPluginPreferencesValue('ALLOW_TAG_CHANGE');

     return 1 if !$allowModifyPrefNames;    # anyone is allowed to change

-- MartinKaufmann - 19 Nov 2009

I'm not sure we want to unsecure by default, (seeing as its been admin group forever), but there is a need to be able to set it to something for a set of 'all registered users' - setting to WikiGuest should imo make it 'everyone'

-- SvenDowideit - 26 Jun 2011

In this case, the documentation is wrong as it states If not set anyone can change tags while it should say If not set only AdminGroup can change tags.

-- MartinKaufmann - 27 Jun 2011

It should be enough to differentiate "undef" (not explicitly set, default to AdminGroup) and "defined, but false" (set to empty, allow anyone to change tags).

-- FlorianSchlichting - 24 Jul 2012
 

ItemTemplate edit

Summary TagMePlugin: Unable to allow everyone to change tags
ReportedBy MartinKaufmann
Codebase 1.0.7
SVN Range Foswiki-1.0.7, Sun, 20 Sep 2009, build 5061
AppliesTo Extension
Component TagMePlugin
Priority Normal
CurrentState Closed
WaitingFor
Checkins TagMePlugin:976f3c621e60
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches trunk
trunkCheckins TagMePlugin:976f3c621e60
Release01x01Checkins
Topic revision: r7 - 27 Jul 2012, FlorianSchlichting - This page was cached on 13 Apr 2017 - 15:50.

The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License