Item9633: configure will not run and creation of bogus NOT SET dir depending on ErrorDocument setting in apache config.

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.10
Target Release: patch
Applies To: Engine
Component:
Branches:
Reported By: KennethLavrsen
Waiting For:
Last Change By: KennethLavrsen
I am trying to install a fresh Release01x01 from pseudo-install

When I try to run configure I get

Browser reports.

Foswiki Installation Error

Template "oopsaccessdenied" not found.

Check the configuration settings for {TemplateDir} and {TemplatePath}.

The error_log says: script not found or unable to stat: /var/www/Release01x01/core/bin/NOT SET/System, referer: http://merlin.lavrsen.dk/foswiki11/bin/configure

And worst. A directory called NOT SET is created in the bin directory and below that a tmp directory.

Someone has changed the default startup behaviour of configure without testing it with a fresh start.

This error is so severe that I have to give up releasing a 1.1 beta tonight.

-- KennethLavrsen - 06 Sep 2010

The issue is that the 401 error document is set to a Foswiki topic. Apache will send the ErrorDocument with the 401 to the user when it prompts for the password. However because Foswiki is unable to generate a valid page, it crashes, and the user never gets a valid 401 message to respond to the password prompt.

Part of the problem has already been addressed in the sample http configuration, and ApacheConfigGenerator. Configure uses a "default" 401 page. However Foswiki should handle a bad/missing LSC more gracefully and not create phantom NOT SET directories.

  • Foswiki::Configure::Load::readConfig() changed to return true if a valid configuration has been loaded
  • Foswiki.pm BEGIN block sets $Foswiki::cfg{isVALID} = 1 - if a valid config is loaded
  • Foswiki::Engine::CGI::run() returns a simple HTML error if a valid configuration is not available.

This needs close review.

-- GeorgeClark - 07 Sep 2010

pharvey pointed out that 1.0.9 has the same issue. Confirmed - visiting view without a valid localSite.cfg creates a NOT SET directory in bin. Applying same fix to 1.0.10

-- GeorgeClark - 07 Sep 2010
 

ItemTemplate edit

Summary configure will not run and creation of bogus NOT SET dir depending on ErrorDocument setting in apache config.
ReportedBy KennethLavrsen
Codebase 1.0.9, trunk
SVN Range
AppliesTo Engine
Component
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:41615a1685af distro:0c1c3320bf45 distro:edcaf3dfd4b8 distro:e4b821f23f95 distro:5ecd6ccd9788
TargetRelease patch
ReleasedIn 1.0.10
Topic revision: r9 - 08 Sep 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy