Foswiki on GitHub is open for business! Next release meeting: Monday October 13, 1300Z

Item9568: CommentPlugin::commonTagsHandler has wrong signature

Priority: CurrentState: AppliesTo: Component: WaitingFor:
Low Waiting for Release Extension CommentPlugin  
The signature of CommentPlugin::commonTagsHandler is missing the $included argument.

From CommentPlugin.pm
sub commonTagsHandler {
    my ( $text, $topic, $web, $meta ) = @_;

From Foswiki.pm expandMacros()
    # Plugin Hook
    $this->{plugins}
      ->dispatch( 'commonTagsHandler', $text, $topicContext, $webContext, 0,
        $topicObject );

Fortunately CommentPlugin doesn't use $included or $meta in commonTagsHandler but it is a bug.

-- BryanThale - 27 Aug 2010

Will be released in 1.1.1

 

ItemTemplate edit

Summary CommentPlugin::commonTagsHandler has wrong signature
ReportedBy BryanThale
Codebase 1.0.9, trunk
SVN Range 8760
AppliesTo Extension
Component CommentPlugin
Priority Low
CurrentState Waiting for Release
WaitingFor
Checkins distro:5bfc13e8a7d3 distro:8ceb61054e04
TargetRelease minor
ReleasedIn 1.2.0
Topic revision: r6 - 19 Oct 2010, KennethLavrsen
 
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. see CopyrightStatement. Creative Commons License