cross
Foswiki General Assembly will be held on 28th November 2019, 1200 UTC on Freenode IRC channel #foswiki-association. See AgendaTenthGeneralAssembly
You are here: Foswiki>Tasks Web>Item9568 (05 Jul 2015, GeorgeClark)Edit Attach

Item9568: CommentPlugin::commonTagsHandler has wrong signature

pencil
Priority: Low
Current State: Closed
Released In: 2.0.0
Target Release: major
Applies To: Extension
Component: CommentPlugin
Branches:
Reported By: BryanThale
Waiting For:
Last Change By: GeorgeClark
The signature of CommentPlugin::commonTagsHandler is missing the $included argument.

From CommentPlugin.pm
sub commonTagsHandler {
    my ( $text, $topic, $web, $meta ) = @_;

From Foswiki.pm expandMacros()
    # Plugin Hook
    $this->{plugins}
      ->dispatch( 'commonTagsHandler', $text, $topicContext, $webContext, 0,
        $topicObject );

Fortunately CommentPlugin doesn't use $included or $meta in commonTagsHandler but it is a bug.

-- BryanThale - 27 Aug 2010

Will be released in 1.1.1

 

ItemTemplate edit

Summary CommentPlugin::commonTagsHandler has wrong signature
ReportedBy BryanThale
Codebase 1.0.9, trunk
SVN Range 8760
AppliesTo Extension
Component CommentPlugin
Priority Low
CurrentState Closed
WaitingFor
Checkins distro:5bfc13e8a7d3 distro:8ceb61054e04
TargetRelease major
ReleasedIn 2.0.0
Topic revision: r7 - 05 Jul 2015, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy