Item9489: TablePlugin sort should strip extraneous HTML from string data before comparing

pencil
Priority: Urgent
Current State: Closed
Released In: 1.0.10
Target Release: patch
Applies To: Extension
Component: TablePlugin
Branches:
Reported By: CrawfordCurrie
Waiting For:
Last Change By: KennethLavrsen
Prior to some version of Foswiki, the sort in the TablePlugin stripped extraneous HTML from string data before comparing.

This behaviour has been changed.
===================================================================
--- Core.pm     (revision 6090)
+++ Core.pm     (working copy)
@@ -1316,12 +1316,12 @@
                 # SMELL: efficient? That's not efficient!
                 @curTable = map { $_->[0] }
                   sort { $b->[1] cmp $a->[1] }
-                  map { [ $_, lc( $_->[$sortCol]->{text} ) ] } @curTable;
+                  map { [ $_, lc( _stripHtml( $_->[$sortCol]->{text} )) ] } @curTable;
             }
             if ( $currentSortDirection == $sortDirection{'ASCENDING'} ) {
                 @curTable = map { $_->[0] }
                   sort { $a->[1] cmp $b->[1] }
-                  map { [ $_, lc( $_->[$sortCol]->{text} ) ] } @curTable;
+                  map { [ $_, lc( _stripHtml( $_->[$sortCol]->{text} )) ] } @curTable;
             }
         }
         else {
has to be restored.

This is already fixed in trunk.

-- CrawfordCurrie - 18 Aug 2010

applied, i wonder why Crawford didn't smile

-- SvenDowideit - 24 Aug 2010

priorities

-- CrawfordCurrie - 27 Aug 2010
 

ItemTemplate edit

Summary TablePlugin sort should strip extraneous HTML from string data before comparing
ReportedBy CrawfordCurrie
Codebase 1.0.9
SVN Range
AppliesTo Extension
Component TablePlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:8eaff86a0f6d
TargetRelease patch
ReleasedIn 1.0.10
Topic revision: r7 - 08 Sep 2010, KennethLavrsen - This page was cached on 03 Sep 2015 - 17:11. Get a fresh version here.
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License